Just use test_result instead of 2 args

Author: aidangarske

.github/scripts/check-workflow-result.sh

@@ -3,14 +3,13 @@
 set -e
 
 if [ $# -lt 2 ]; then
-    echo "Usage: $0 <build_result> <test_result> [WOLFPROV_FORCE_FAIL] [TEST_SUITE]"
+    echo "Usage: $0 <test_result> [WOLFPROV_FORCE_FAIL] [TEST_SUITE]"
     exit 1
 fi
 
-BUILD_RESULT="$1"
-TEST_RESULT="$2"
-WOLFPROV_FORCE_FAIL="${3:-}"
-TEST_SUITE="${4:-}"
+TEST_RESULT="$1"
+WOLFPROV_FORCE_FAIL="${2:-}"
+TEST_SUITE="${3:-}"
 
 if [ "$WOLFPROV_FORCE_FAIL" = "1" ]; then
     if [ "$TEST_SUITE" = "curl" ]; then
@@ -74,7 +73,7 @@ if [ "$WOLFPROV_FORCE_FAIL" = "1" ]; then
         # --- simple test suite specific logic ---
         if [ -f "test-suite.log" ]; then
             # For simple tests, we expect all tests to fail when force fail is enabled
-            if [ $BUILD_RESULT -eq 0 ] || [ $TEST_RESULT -eq 0 ]; then
+            if [ $TEST_RESULT -eq 0 ]; then
                 echo "Simple tests unexpectedly succeeded with force fail enabled"
                 exit 1
             else
@@ -87,20 +86,16 @@ if [ "$WOLFPROV_FORCE_FAIL" = "1" ]; then
         fi
     else
         # --- generic force-fail logic for other suites ---
-        if [ $BUILD_RESULT -eq 0 ] || [ $TEST_RESULT -eq 0 ]; then
-            echo "Build/Test unexpectedly succeeded with force fail enabled"
+        if [ $TEST_RESULT -eq 0 ]; then
+            echo "Test unexpectedly succeeded with force fail enabled"
             exit 1 # failure was not seen when expected
         else
-            echo "Build/Test failed as expected with force fail enabled"
+            echo "Test failed as expected with force fail enabled"
             exit 0 # expected failure occurred
         fi
     fi
-elif [ $BUILD_RESULT -ne 0 ] || [ $TEST_RESULT -ne 0 ]; then
-    if [ $BUILD_RESULT -eq 2 ]; then
-        echo "Build/test setup failed unexpectedly"
-    else
-        echo "Tests failed unexpectedly"
-    fi
+elif [ $TEST_RESULT -ne 0 ]; then
+    echo "Tests failed unexpectedly"
     exit 1
 else
     echo "Tests passed successfully"