Testing: add GitHub action to check all lines are <= 80 characters

Author: cconlon

.github/workflows/line-length-check.yml

@@ -0,0 +1,80 @@
+name: Line Length Check
+
+on:
+  pull_request:
+    branches: [ '*' ]
+
+jobs:
+  line-length-check:
+    runs-on: ubuntu-latest
+    name: Check 80 character line limit
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+
+    - name: Check line length in PR changes
+      run: |
+        # Get the base branch (usually main/master)
+        BASE_BRANCH="${{ github.event.pull_request.base.ref }}"
+
+        echo "Checking line length (max 80 characters) for changed files in " \
+          "src/, examples/, and jni/ directories..."
+        echo "================================================================"
+
+        # Get all changed files in this PR and filter for target directories
+        git diff --name-only "origin/$BASE_BRANCH"...HEAD | \
+          grep -E '^(src/|examples/|jni/)' > changed_files.txt || true
+
+        # Create a temporary file to collect violations
+        violation_count=0
+        echo > violations.tmp
+
+        # Check each changed file
+        while IFS= read -r file; do
+          if [[ -f "$file" ]]; then
+            echo "Checking: $file"
+
+            # Get added lines and check their length
+            git diff "origin/$BASE_BRANCH"...HEAD "$file" | \
+              grep '^+' | grep -v '^+++' | \
+              while read -r added_line; do
+                # Remove the leading +
+                actual_line="${added_line:1}"
+                char_count=${#actual_line}
+
+                if [[ $char_count -gt 80 ]]; then
+                  echo "❌ $file - Line too long ($char_count characters)"
+                  echo "   Line: $actual_line"
+                  echo "violation" >> violations.tmp
+                fi
+              done
+          fi
+        done < changed_files.txt
+
+        # Count violations
+        if [[ -f violations.tmp ]]; then
+          violation_count=$(grep -c "violation" violations.tmp || echo 0)
+        else
+          violation_count=0
+        fi
+
+        echo "================================================================"
+
+        if [[ $violation_count -gt 0 ]]; then
+          echo "❌ Found $violation_count line(s) exceeding 80 " \
+            "characters in PR changes"
+          echo ""
+          echo "Please ensure all lines are 80 characters or less " \
+            "as per coding standards."
+          echo "You can check line length in your editor or use this command:"
+          echo "  grep -n '.\{81,\}' <filename>"
+          rm -f violations.tmp changed_files.txt
+          exit 1
+        else
+          echo "✅ All changed lines are within the 80 character limit"
+          rm -f violations.tmp changed_files.txt
+          exit 0
+        fi

src/main/java/com/wolfssl/wolfcrypt/Ecc.java

@@ -36,6 +36,7 @@ public class Ecc extends NativeStruct {
     /* used with native wc_ecc_set_rng() */
     private Rng rng = null;
 
+    /* this is a long comment that goes over 80 character and is a good test to see if our new GH action catches it */
     /* Do we own the Rng struct, or has that been passed in? Used
      * during Rng cleanup. */
     private boolean weOwnRng = true;
@@ -60,6 +61,7 @@ public Ecc() {
         /* Internal state is initialized on first use */
     }
 
+    private String tmpVarTooLong = "This is also a very long line of code that goes over 80 characters, let's see if GH action catches it.";
     /**
      * Create new Ecc object with existing Rng object.
      *