Customer reported possible unitialized usage

anhu · anhu · commit 12d37328acb6 · 2025-04-28T16:13:42.000-04:00
diff --git a/src/internal.c b/src/internal.c
@@ -8353,7 +8353,7 @@ static int DoChannelOpen(WOLFSSH* ssh,
 static int DoChannelOpenConf(WOLFSSH* ssh,
                              byte* buf, word32 len, word32* idx)
 {
-    WOLFSSH_CHANNEL* channel;
+    WOLFSSH_CHANNEL* channel = NULL;
     word32 begin, channelId, peerChannelId,
            peerInitialWindowSz, peerMaxPacketSz;
     int ret = WS_SUCCESS;

Original file line number	Diff line number	Diff line change
`@@ -8353,7 +8353,7 @@ static int DoChannelOpen(WOLFSSH* ssh,`
`8353`	`8353`	`static int DoChannelOpenConf(WOLFSSH* ssh,`
`8354`	`8354`	`byte* buf, word32 len, word32* idx)`
`8355`	`8355`	`{`
`8356`		`- WOLFSSH_CHANNEL* channel;`
	`8356`	`+ WOLFSSH_CHANNEL* channel = NULL;`
`8357`	`8357`	`word32 begin, channelId, peerChannelId,`
`8358`	`8358`	`peerInitialWindowSz, peerMaxPacketSz;`
`8359`	`8359`	`int ret = WS_SUCCESS;`