Fix SFTP Symlinks

ejohnstown · ejohnstown · commit 3386b636cf5a · 2025-03-20T09:02:39.000-07:00
1. When making a longname, mask the permission file type bits and check
   it being a link.
2. Mask the permission bits the same way for checking the item being a
   directory.
diff --git a/src/wolfsftp.c b/src/wolfsftp.c
@@ -2612,10 +2612,10 @@ static int SFTP_CreateLongName(WS_SFTPNAME* name)
         word32 tmp = atr->per;
 
         i = 0;
-        if (tmp & FILEATRB_PER_DIR) {
+        if ((tmp & FILEATRB_PER_MASK_TYPE) == FILEATRB_PER_DIR) {
             perm[i++] = 'd';
         }
-        else if (tmp & FILEATRB_PER_LINK) {
+        else if ((tmp & FILEATRB_PER_MASK_TYPE) == FILEATRB_PER_LINK) {
             perm[i++] = 'l';
         }
         else {

Original file line number	Diff line number	Diff line change
`@@ -2612,10 +2612,10 @@ static int SFTP_CreateLongName(WS_SFTPNAME* name)`
`2612`	`2612`	`word32 tmp = atr->per;`
`2613`	`2613`
`2614`	`2614`	`i = 0;`
`2615`		`- if (tmp & FILEATRB_PER_DIR) {`
	`2615`	`+ if ((tmp & FILEATRB_PER_MASK_TYPE) == FILEATRB_PER_DIR) {`
`2616`	`2616`	`perm[i++] = 'd';`
`2617`	`2617`	`}`
`2618`		`- else if (tmp & FILEATRB_PER_LINK) {`
	`2618`	`+ else if ((tmp & FILEATRB_PER_MASK_TYPE) == FILEATRB_PER_LINK) {`
`2619`	`2619`	`perm[i++] = 'l';`
`2620`	`2620`	`}`
`2621`	`2621`	`else {`