coverity: do not free x509 on error in wolfSSL_add0_chain_cert.

philljj · philljj · commit 68cf96e7f61b · 2025-06-27T17:25:28.000-05:00
diff --git a/src/ssl_load.c b/src/ssl_load.c
@@ -5108,11 +5108,6 @@ int wolfSSL_add0_chain_cert(WOLFSSL* ssl, WOLFSSL_X509* x509)
             /* Push X509 object onto stack to be freed. */
             ret = wolfSSL_sk_X509_push(ssl->ourCertChain, x509) > 0
                     ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
-            if (ret != 1) {
-                /* Free it now on error. */
-                wolfSSL_X509_free(x509);
-                x509 = NULL;
-            }
         }
     }
     return WS_RC(ret);

Original file line number	Diff line number	Diff line change
`@@ -5108,11 +5108,6 @@ int wolfSSL_add0_chain_cert(WOLFSSL* ssl, WOLFSSL_X509* x509)`
`5108`	`5108`	`/* Push X509 object onto stack to be freed. */`
`5109`	`5109`	`ret = wolfSSL_sk_X509_push(ssl->ourCertChain, x509) > 0`
`5110`	`5110`	`? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;`
`5111`		`- if (ret != 1) {`
`5112`		`- /* Free it now on error. */`
`5113`		`- wolfSSL_X509_free(x509);`
`5114`		`- x509 = NULL;`
`5115`		`- }`
`5116`	`5111`	`}`
`5117`	`5112`	`}`
`5118`	`5113`	`return WS_RC(ret);`