Revert all temporary tests

Author: mattia-moffa

.github/workflows/os-check.yml

@@ -70,7 +70,7 @@ jobs:
       - name: Build and test wolfSSL
         uses: wolfSSL/actions-build-autotools-project@v1
         with:
-          configure: CFLAGS="-pedantic -Wno-overlength-strings -Wdeclaration-after-statement -DTEST_LIBWOLFSSL_SOURCES_INCLUSION_SEQUENCE" ${{ matrix.config }} --enable-debug
+          configure: CFLAGS="-pedantic -Wno-overlength-strings -Wdeclaration-after-statement -DTEST_LIBWOLFSSL_SOURCES_INCLUSION_SEQUENCE" ${{ matrix.config }}
           check: true
 
   make_user_settings:

tests/api.c

@@ -8044,8 +8044,6 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
     tcp_accept(
         &sockfd, &clientfd, opts, port, 0, doUdp, 0, 0, 1, 0, 0);
 
-    printf("test_server_nofail: after tcp_accept\n");
-
     if (doUdp) {
         cliLen = sizeof(cliAddr);
 
@@ -8085,8 +8083,6 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
         goto done;
     }
 
-    printf("test_server_nofail: after use certificate file\n");
-
     if (cbf != NULL && cbf->keyPemFile != NULL)
         keyFile = cbf->keyPemFile;
 #if defined(OPENSSL_EXTRA) || defined(WOLFSSL_EITHER_SIDE)
@@ -8101,8 +8097,6 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
         goto done;
     }
 
-    printf("test_server_nofail: after use private key file\n");
-
 #ifdef HAVE_CRL
     if (cbf != NULL && cbf->crlPemFile != NULL) {
         if (wolfSSL_CTX_EnableCRL(ctx, WOLFSSL_CRL_CHECKALL) != WOLFSSL_SUCCESS)
@@ -8119,14 +8113,12 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
     }
 
     ssl = wolfSSL_new(ctx);
-    printf("test_server_nofail: after wolfSSL_new. ssl = %p\n", (void*)ssl);
     if (ssl == NULL) {
         goto done;
     }
 
     if (doUdp) {
         err = wolfSSL_dtls_set_peer(ssl, &cliAddr, cliLen);
-        printf("test_server_nofail: after wolfSSL_dtls_set_peer. err = %d\n", err);
         if (err != WOLFSSL_SUCCESS)
             goto done;
     }
@@ -8166,7 +8158,6 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
         /*err_sys("SSL_set_fd failed");*/
         goto done;
     }
-    printf("test_server_nofail: after wolfSSL_set_fd\n");
 
 #if !defined(NO_FILESYSTEM) && !defined(NO_DH)
     wolfSSL_SetTmpDH_file(ssl, dhParamFile, WOLFSSL_FILETYPE_PEM);
@@ -8199,12 +8190,9 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
         char buff[WOLFSSL_MAX_ERROR_SZ];
         fprintf(stderr, "error = %d, %s\n", err,
             wolfSSL_ERR_error_string((word32)err, buff));
-        fprintf(stdout, "wolfSSL_negotiate error = %d, %s\n", err,
-            wolfSSL_ERR_error_string((word32)err, buff));
         /*err_sys("SSL_accept failed");*/
         goto done;
     }
-    printf("test_server_nofail: after wolfSSL_negotiate. ret = %d\n", ret);
 
 #ifdef WOLFSSL_HAVE_TLS_UNIQUE
     XMEMSET(server_side_msg2, 0, WC_MAX_DIGEST_SIZE);
@@ -8217,7 +8205,6 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
 #endif /* WOLFSSL_HAVE_TLS_UNIQUE */
 
     idx = wolfSSL_read(ssl, input, sizeof(input)-1);
-    printf("test_server_nofail: after wolfSSL_read. idx = %d\n", idx);
     if (idx > 0) {
         input[idx] = '\0';
         fprintf(stderr, "Client message: %s\n", input);
@@ -8227,11 +8214,9 @@ THREAD_RETURN WOLFSSL_THREAD test_server_nofail(void* args)
     }
 
     if (wolfSSL_write(ssl, msg, sizeof(msg)) != sizeof(msg)) {
-        printf("test_server_nofail: wolfSSL_write error\n");
         /*err_sys("SSL_write failed");*/
         goto done;
     }
-    printf("test_server_nofail: after wolfSSL_write\n");
 
     if (cbf != NULL && cbf->on_result != NULL)
         cbf->on_result(ssl);

tests/api/test_tls_ext.c

@@ -146,17 +146,10 @@ static int certificate_authorities_client_cb(WOLFSSL *ssl, void *_arg) {
     arg->names1 = wolfSSL_get_client_CA_list(ssl);
     arg->names2 = wolfSSL_get0_peer_CA_list(ssl);
 
-    printf("(client cb)\n");
-    fflush(stdout);
-
     if (!wolfSSL_use_certificate_file(ssl, cliCertFile, SSL_FILETYPE_PEM))
         return 0;
     if (!wolfSSL_use_PrivateKey_file(ssl, cliKeyFile, SSL_FILETYPE_PEM))
         return 0;
-
-    printf("(client cb) arg->names1 = %p\n", (void*)arg->names1);
-    printf("(client cb) arg->names2 = %p\n", (void*)arg->names2);
-    fflush(stdout);
     return 1;
 }
 #endif
@@ -202,35 +195,6 @@ int test_certificate_authorities_certificate_request(void) {
         if (EXPECT_FAIL())
             break;
 
-#ifdef WOLFSSL_TLS13
-        if (params[i].client_meth == wolfTLSv1_3_client_method) {
-            printf("TLS 1.3\n");
-        }
-        else
-#endif
-#if !defined(WOLFSSL_NO_TLS12) && (defined(OPENSSL_ALL) || \
-        defined(WOLFSSL_NGINX) || defined(HAVE_LIGHTY))
-        if (params[i].client_meth == wolfTLSv1_2_client_method) {
-            printf("TLS 1.2\n");
-        }
-        else
-#endif
-#ifdef WOLFSSL_DTLS13
-        if (params[i].client_meth == wolfDTLSv1_3_client_method) {
-            printf("DTLS 1.3\n");
-        }
-        else
-#endif
-#if defined(WOLFSSL_DTLS) && (defined(OPENSSL_ALL) || \
-        defined(WOLFSSL_NGINX) || defined(HAVE_LIGHTY))
-        if (params[i].client_meth == wolfDTLSv1_2_client_method) {
-            printf("DTLS 1.2\n");
-        }
-        else
-#endif
-        {}
-        fflush(stdout);
-
         ExpectNotNull(ctx = wolfSSL_CTX_new(params[i].server_meth()));
 
         names1 = wolfSSL_load_client_CA_file(cliCertFile);
@@ -368,14 +332,10 @@ static int certificate_authorities_server_cb(WOLFSSL *ssl, void *_arg) {
     int *names_num = (int *)_arg;
     WOLF_STACK_OF(X509_NAME) *names = wolfSSL_get0_peer_CA_list(ssl);
     *names_num = wolfSSL_sk_X509_NAME_num(names);
-    printf("(server cb)\n");
-    fflush(stdout);
     if (!wolfSSL_use_certificate_file(ssl, svrCertFile, SSL_FILETYPE_PEM))
         return 0;
     if (!wolfSSL_use_PrivateKey_file(ssl, svrKeyFile, SSL_FILETYPE_PEM))
         return 0;
-    printf("(server cb) names_num = %p %d\n", (void*)names_num, *names_num);
-    fflush(stdout);
     return 1;
 }
 #endif

wolfssl/test.h

@@ -1729,8 +1729,6 @@ static WC_INLINE void tcp_accept(SOCKET_T* sockfd, SOCKET_T* clientfd,
     if(do_listen) {
         tcp_listen(sockfd, &port, useAnyAddr, udp, sctp);
 
-    printf("tcp_accept: after udp_accept & tcp_listen\n");
-
 #ifndef SINGLE_THREADED
         /* signal ready to tcp_accept */
         if (args)