20251114-WOLFSSL_BLIND_PRIVATE_KEY-thread-safety #9436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
Jenkins retest this please: PRB-generic-config-parser aborted |
dgarske
previously approved these changes
Nov 14, 2025
julek-wolfssl
previously requested changes
Nov 14, 2025
…,altPrivateKeyMask} in WOLFSSL_BLIND_PRIVATE_KEY code paths: * rename wolfssl_priv_der_unblind() to wolfssl_priv_der_blind_toggle(), * add wolfssl_priv_der_unblind() that allocates a temp copy, * add wolfssl_priv_der_unblind_free(), * in wolfssl_priv_der_blind_toggle(), make mask a const arg; restore const attribute to ctx arg to wolfSSL_CTX_get0_privatekey(), and add explanatory comment.
…wolfssl_priv_der_unblind_free() to use AllocDer() and FreeDer().
douzzer
force-pushed
the
20251114-WOLFSSL_BLIND_PRIVATE_KEY-thread-safety
branch
from
e82110b to
c29abcc
Compare
Contributor
Author
|
note, this is a follow-up to #9427 |
dgarske
approved these changes
Nov 17, 2025
JacobBarthelmeh
dismissed
julek-wolfssl’s stale review
Items brought up were addressed
JacobBarthelmeh
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix races around
WOLFSSL_CTX.{privateKey,privateKeyMask,altPrivateKey,altPrivateKeyMask}inWOLFSSL_BLIND_PRIVATE_KEYcode paths:wolfssl_priv_der_unblind()towolfssl_priv_der_blind_toggle(),wolfssl_priv_der_unblind()that allocates a temp copy,wolfssl_priv_der_unblind_free(),wolfssl_priv_der_blind_toggle(), makemaskaconstarg;restore
constattribute toctxarg towolfSSL_CTX_get0_privatekey(), and add explanatory comment.tested with
wolfssl-multi-test.sh ... check-source-text clang-tidy-all-sp-allAlso ran
clang-tidy-all-sp-allwithLIBWOLFSSL_CONFIGURE_ARGS_OVERRIDE=CFLAGS=-DWOLFSSL_BLIND_PRIVATE_KEY, which is analytically clean, but crashes, unrelated to this PR: