Fix cert SW issues in Aes and rng #9681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizlik
reviewed
Jan 20, 2026
dgarske
approved these changes
Jan 20, 2026
rizlik
approved these changes
Jan 20, 2026
Contributor
Author
|
Jenkins retest this please |
1 similar comment
Contributor
Author
|
Jenkins retest this please |
Contributor
|
Jenkins retest this please: "RequestAbortedException" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks for the validity of the seed buffer and the seedSz parameter. When seedSz is less than SEED_BLOCK_SZ (Word32 = 4), the loop can underflow and iterate to the Word32 limit, resulting in an infinite loop and a crash.
Updates wc_AesEncryptDirect to return a negative error code when the input data buffer is NULL. Previously, the function returned 0 and exhibited undefined behavior.
Fixed in https://github.com/wolfSSL/wolfBoot-private/pull/70
Testing
How did you test?
Checklist