Skip to content

Commit 21870b1

Browse files
committed
set severity to warning
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
1 parent 439fb7d commit 21870b1

File tree

4 files changed

+21
-13
lines changed

4 files changed

+21
-13
lines changed

pkg/lint/rules.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ var AllRules = func(l *Linter) Rules { //nolint:gocyclo
471471
{
472472
Name: "valid-version-stream",
473473
Description: "check the provides and tag filter if version stream suffix is passed to package name",
474-
Severity: SeverityError,
474+
Severity: SeverityWarning,
475475
LintFunc: func(c config.Configuration) error {
476476
// This regex captures a string that ends with a semantic version (semver) suffix.
477477
// It returns two groups:

pkg/lint/rules_test.go

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -412,19 +412,21 @@ func TestLinter_Rules(t *testing.T) {
412412
},
413413
},
414414
},
415+
wantErr: false,
416+
matches: 1,
415417
},
416418
{
417419
file: "version-stream-missing-provides-1.2.yaml",
418-
minSeverity: SeverityError,
420+
minSeverity: SeverityWarning,
419421
want: EvalResult{
420422
File: "version-stream-missing-provides-1.2",
421423
Errors: EvalRuleErrors{
422424
{
423425
Rule: Rule{
424426
Name: "valid-version-stream",
425-
Severity: SeverityError,
427+
Severity: SeverityWarning,
426428
},
427-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but version-stream-missing-provides=${{package.full-version}} is missing on dependencies.provides (ERROR)"),
429+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but version-stream-missing-provides=${{package.full-version}} is missing on dependencies.provides (WARNING)"),
428430
},
429431
},
430432
},
@@ -433,16 +435,16 @@ func TestLinter_Rules(t *testing.T) {
433435
},
434436
{
435437
file: "version-stream-missing-update-tagfilter-1.2.yaml",
436-
minSeverity: SeverityError,
438+
minSeverity: SeverityWarning,
437439
want: EvalResult{
438440
File: "version-stream-missing-update-tagfilter-1.2",
439441
Errors: EvalRuleErrors{
440442
{
441443
Rule: Rule{
442444
Name: "valid-version-stream",
443-
Severity: SeverityError,
445+
Severity: SeverityWarning,
444446
},
445-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (ERROR)"),
447+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (WARNING)"),
446448
},
447449
},
448450
},
@@ -451,16 +453,16 @@ func TestLinter_Rules(t *testing.T) {
451453
},
452454
{
453455
file: "version-stream-missing-update-tagfilter-1.2-999.yaml",
454-
minSeverity: SeverityError,
456+
minSeverity: SeverityWarning,
455457
want: EvalResult{
456458
File: "version-stream-missing-update-tagfilter-1.2",
457459
Errors: EvalRuleErrors{
458460
{
459461
Rule: Rule{
460462
Name: "valid-version-stream",
461-
Severity: SeverityError,
463+
Severity: SeverityWarning,
462464
},
463-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (ERROR)"),
465+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but tag filter 1.2 is mismatch on update.github (WARNING)"),
464466
},
465467
},
466468
},
@@ -485,16 +487,16 @@ func TestLinter_Rules(t *testing.T) {
485487
},
486488
{
487489
file: "version-stream-mismatch-version-1.2.yaml",
488-
minSeverity: SeverityError,
490+
minSeverity: SeverityWarning,
489491
want: EvalResult{
490492
File: "version-stream-mismatch-version-1.2",
491493
Errors: EvalRuleErrors{
492494
{
493495
Rule: Rule{
494496
Name: "valid-version-stream",
495-
Severity: SeverityError,
497+
Severity: SeverityWarning,
496498
},
497-
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but package.version 1.7 starts with different than given version stream 1.2 (ERROR)"),
499+
Error: fmt.Errorf("[valid-version-stream]: package is version streamed but package.version 1.7 starts with different than given version stream 1.2 (WARNING)"),
498500
},
499501
},
500502
},

pkg/lint/testdata/files/version-stream-mismatch-version-1.2.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,6 @@ pipeline:
1313
test:
1414
pipeline:
1515
- runs: "echo 'test'"
16+
17+
update:
18+
enabled: true

pkg/lint/testdata/files/version-stream-missing-provides-1.2.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,6 @@ pipeline:
1313
test:
1414
pipeline:
1515
- runs: "echo 'test'"
16+
17+
update:
18+
enabled: true

0 commit comments

Comments
 (0)