Skip to content

Commit e1083e4

Browse files
authored
Merge pull request #3288 from woocommerce/feature/GOOWOO-383-genai-assets
Feature: Gen AI Assets (Phase 1)
2 parents e1b64e3 + c7655af commit e1083e4

File tree

108 files changed

+5655
-1178
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

108 files changed

+5655
-1178
lines changed

bin/GoogleAdsCleanupServices.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class GoogleAdsCleanupServices {
2626
*
2727
* @var string
2828
*/
29-
protected $version = 'V20';
29+
protected $version = 'V22';
3030

3131
/**
3232
* @var Event Composer event.
@@ -52,12 +52,11 @@ class GoogleAdsCleanupServices {
5252
* @var string[] List of Service to NOT remove even when usage is not found.
5353
*/
5454
protected $avoid_cleanup = [
55-
// Some methods like `ResourceNames::forGeoTargetConstant` are changed to use
56-
// `BatchJobServiceClient` class instead of `GoogleAdsServiceClient` when
57-
// upgrading from v18 to v20, so we need to keep this service. See:
58-
// - https://github.com/googleads/google-ads-php/blob/v28.0.0/src/Google/Ads/GoogleAds/Util/V18/ResourceNames.php#L1704-L1710
55+
// ConversionValueRuleService is now used in `ResourceNames::forGeoTargetConstant` in V22.
56+
// instead of the previous BatchJobServiceClient. See:
5957
// - https://github.com/googleads/google-ads-php/blob/v28.0.0/src/Google/Ads/GoogleAds/Util/V20/ResourceNames.php#L1433-L1439
60-
'BatchJob',
58+
// - https://github.com/googleads/google-ads-php/blob/v31.1.0/src/Google/Ads/GoogleAds/Util/V22/ResourceNames.php#L1457-L1463
59+
'ConversionValueRule',
6160
];
6261

6362
/**

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"ext-json": "*",
1010
"google/apiclient": "^2.16",
1111
"google/apiclient-services": "^0.350.0",
12-
"googleads/google-ads-php": "dev-legacy-v31.0.1",
12+
"googleads/google-ads-php": "dev-legacy-v31.1.0",
1313
"league/container": "^4.2",
1414
"league/iso3166": "^4.1",
1515
"phpseclib/bcmath_compat": "^2.0",
@@ -60,7 +60,7 @@
6060
"Google\\Task\\Composer::cleanup",
6161
"Automattic\\WooCommerce\\GoogleListingsAndAds\\Util\\SymfonyPolyfillCleanup::remove",
6262
"Automattic\\WooCommerce\\GoogleListingsAndAds\\Util\\GoogleAdsCleanupServices::remove",
63-
"composer run-script remove-google-ads-api-version-support -- 18 19 21",
63+
"composer run-script remove-google-ads-api-version-support -- 18 19 20 21",
6464
"php ./bin/prefix-vendor-namespace.php",
6565
"bash ./bin/cleanup-vendor-files.sh",
6666
"composer dump-autoload"

0 commit comments

Comments
 (0)