Add protection around mock queries in unit tests. (#3602)

* Add protection around mock queries in unit tests.

This adds additional checks before mocking wc_get_orders query results to prevent overriding refunds query. This is needed with WC core 4.9 since it does an addtional wc_get_orders query to preload and hydrate cache for refunds in order to improve performance.

* update jetpack autoloader to 2.7.1

Co-authored-by: Seghir Nadir <[email protected]>

Author: vedanshujain

tests/php/Domain/Services/DeleteDraftOrders.php

@@ -123,9 +123,11 @@ public function test_delete_expired_draft_orders() {
 	}
 
 	public function test_greater_than_batch_results_error() {
-		$sample_results = function() {
-			return array_fill( 0, 21, ( new WC_Order ) );
-
+		$sample_results = function( $results, $args ) {
+			if ( isset( $args[ 'status' ] ) && DraftOrders::DB_STATUS === $args[ 'status' ] ) {
+				return array_fill( 0, 21, ( new WC_Order ) );
+			}
+			return $results;
 		};
 		$this->mock_results_for_wc_query($sample_results);
 		$this->draft_orders_instance->delete_expired_draft_orders();
@@ -134,8 +136,11 @@ public function test_greater_than_batch_results_error() {
 	}
 
 	public function test_order_not_instance_of_wc_order_error() {
-		$sample_results = function() {
-			return [ 10 ];
+		$sample_results = function( $results, $args ) {
+			if ( isset( $args[ 'status' ] ) && DraftOrders::DB_STATUS === $args[ 'status' ] ) {
+				return [ 10 ];
+			}
+			return $results;
 		};
 		$this->mock_results_for_wc_query( $sample_results );
 		$this->draft_orders_instance->delete_expired_draft_orders();
@@ -144,10 +149,13 @@ public function test_order_not_instance_of_wc_order_error() {
 	}
 
 	public function test_order_incorrect_status_error() {
-		$sample_results = function() {
-			$test_order = new WC_Order();
-			$test_order->set_status( 'on-hold' );
-			return [ $test_order ];
+		$sample_results = function( $results, $args ) {
+			if ( isset( $args[ 'status' ] ) && DraftOrders::DB_STATUS === $args[ 'status' ] ) {
+				$test_order = new WC_Order();
+				$test_order->set_status( 'on-hold' );
+				return [ $test_order ];
+			}
+			return $results;
 		};
 		$this->mock_results_for_wc_query( $sample_results );
 		$this->draft_orders_instance->delete_expired_draft_orders();
@@ -182,10 +190,11 @@ public function test_order_status_verification() {
 	}
 
 	private function mock_results_for_wc_query( $mock_callback ) {
-		add_filter( 'woocommerce_order_query', $mock_callback );
+		add_filter( 'woocommerce_order_query', $mock_callback, 10, 2 );
 	}
 
 	private function unset_mock_results_for_wc_query( $mock_callback ) {
-		remove_filter( 'woocommerce_order_query', $mock_callback );
+		$removed = remove_filter( 'woocommerce_order_query', $mock_callback );
+		$this->assertTrue( $removed );
 	}
 }