Update dependencies order (#1146)

* Update dependencies order

* Create eslint WooCommerce plugin with dependency group rule

* Update WCPackageLocality definition so it only includes External and Internal

* Rename WPPackageLocality to WCPackageLocality

* Delete old typedef

Author: Aljullu

.eslintrc.js

@@ -6,9 +6,10 @@ module.exports = {
 	globals: {
 		wcSettings: true,
 	},
-	plugins: [ 'jest' ],
+	plugins: [ 'jest', 'woocommerce' ],
 	rules: {
 		'@wordpress/dependency-group': 'off',
+		'woocommerce/dependency-group': 'error',
 		'valid-jsdoc': 'off',
 		yoda: [ 'error', 'never' ],
 	},

assets/js/atomic/blocks/product/button/index.js

@@ -5,11 +5,11 @@ import { __ } from '@wordpress/i18n';
 import { registerBlockType } from '@wordpress/blocks';
 import { Disabled } from '@wordpress/components';
 import Gridicon from 'gridicons';
+import { ProductButton } from '@woocommerce/atomic-components/product';
 
 /**
  * Internal dependencies
  */
-import { ProductButton } from '@woocommerce/atomic-components/product';
 import sharedConfig from '../shared-config';
 
 const blockConfig = {

assets/js/atomic/blocks/product/image/index.js

@@ -7,14 +7,14 @@ import Gridicon from 'gridicons';
 import { Fragment } from '@wordpress/element';
 import { Disabled, PanelBody, ToggleControl } from '@wordpress/components';
 import { InspectorControls } from '@wordpress/editor';
+import ToggleButtonControl from '@woocommerce/block-components/toggle-button-control';
+import { ProductImage } from '@woocommerce/atomic-components/product';
+import { previewProducts } from '@woocommerce/resource-previews';
 
 /**
  * Internal dependencies
  */
-import ToggleButtonControl from '@woocommerce/block-components/toggle-button-control';
-import { ProductImage } from '@woocommerce/atomic-components/product';
 import sharedConfig from '../shared-config';
-import { previewProducts } from '@woocommerce/resource-previews';
 
 const blockConfig = {
 	title: __( 'Product Image', 'woo-gutenberg-products-block' ),

assets/js/atomic/blocks/product/price/index.js

@@ -4,11 +4,11 @@
 import { __ } from '@wordpress/i18n';
 import { registerBlockType } from '@wordpress/blocks';
 import Gridicon from 'gridicons';
+import { ProductPrice } from '@woocommerce/atomic-components/product';
 
 /**
  * Internal dependencies
  */
-import { ProductPrice } from '@woocommerce/atomic-components/product';
 import sharedConfig from '../shared-config';
 
 const blockConfig = {

assets/js/atomic/blocks/product/rating/index.js

@@ -4,11 +4,11 @@
 import { __ } from '@wordpress/i18n';
 import { registerBlockType } from '@wordpress/blocks';
 import Gridicon from 'gridicons';
+import { ProductRating } from '@woocommerce/atomic-components/product';
 
 /**
  * Internal dependencies
  */
-import { ProductRating } from '@woocommerce/atomic-components/product';
 import sharedConfig from '../shared-config';
 
 const blockConfig = {

assets/js/atomic/blocks/product/sale-badge/index.js

@@ -3,13 +3,13 @@
  */
 import { __ } from '@wordpress/i18n';
 import { registerBlockType } from '@wordpress/blocks';
+import { ProductSaleBadge } from '@woocommerce/atomic-components/product';
+import { IconProductOnSale } from '@woocommerce/block-components/icons';
 
 /**
  * Internal dependencies
  */
-import { ProductSaleBadge } from '@woocommerce/atomic-components/product';
 import sharedConfig from '../shared-config';
-import { IconProductOnSale } from '@woocommerce/block-components/icons';
 
 const blockConfig = {
 	title: __( 'On-Sale Badge', 'woo-gutenberg-products-block' ),

assets/js/atomic/blocks/product/shared-config.js

@@ -3,10 +3,6 @@
  */
 import { __ } from '@wordpress/i18n';
 import Gridicon from 'gridicons';
-
-/**
- * Internal dependencies
- */
 import { previewProducts } from '@woocommerce/resource-previews';
 
 /**

assets/js/atomic/blocks/product/summary/index.js

@@ -4,11 +4,11 @@
 import { __ } from '@wordpress/i18n';
 import { registerBlockType } from '@wordpress/blocks';
 import Gridicon from 'gridicons';
+import { ProductSummary } from '@woocommerce/atomic-components/product';
 
 /**
  * Internal dependencies
  */
-import { ProductSummary } from '@woocommerce/atomic-components/product';
 import sharedConfig from '../shared-config';
 
 const blockConfig = {

assets/js/atomic/blocks/product/title/heading-level-icon.js

@@ -1,5 +1,5 @@
 /**
- * WordPress dependencies
+ * External dependencies
  */
 import { Path, SVG } from '@wordpress/components';
 

assets/js/atomic/blocks/product/title/heading-toolbar.js

@@ -2,10 +2,6 @@
  * External dependencies
  */
 import { range } from 'lodash';
-
-/**
- * WordPress dependencies
- */
 import { __, sprintf } from '@wordpress/i18n';
 import { Component } from '@wordpress/element';
 import { Toolbar } from '@wordpress/components';