Breadcrumbs should always at least be empty array.

Author: samueljseay

assets/js/editor-components/product-attribute-term-control/index.tsx

@@ -65,7 +65,7 @@ const ProductAttributeTermControl = ( {
 			},
 		];
 
-		if ( ! item?.breadcrumbs?.length ) {
+		if ( ! item.breadcrumbs.length ) {
 			return (
 				<ExpandableSearchListItem
 					{ ...args }

assets/js/editor-components/product-tag-control/product-tag-item.tsx

@@ -16,7 +16,7 @@ export const ProductTagItem = ( {
 	depth = 0,
 	...rest
 }: renderItemArgs ): JSX.Element => {
-	const accessibleName = ! item?.breadcrumbs?.length
+	const accessibleName = ! item.breadcrumbs.length
 		? item.name
 		: `${ item.breadcrumbs.join( ', ' ) }, ${ item.name }`;
 

assets/js/editor-components/search-list-control/item.tsx

@@ -22,22 +22,12 @@ const Count = ( { label }: { label: string | React.ReactNode | number } ) => {
 	);
 };
 
-type SearchListItemPropsWithBreadcrumb = SearchListItemProps & {
-	breadcrumbs: string[];
-};
-
-const checkHasBreadCrumbs = (
-	item: SearchListItemProps
-): item is SearchListItemPropsWithBreadcrumb => {
-	return !! ( item.breadcrumbs && item.breadcrumbs.length );
-};
-
 const ItemLabel = ( props: { item: SearchListItemProps; search: string } ) => {
 	const { item, search } = props;
 
 	return (
 		<span className="woocommerce-search-list__item-label">
-			{ checkHasBreadCrumbs( item ) ? (
+			{ item.breadcrumbs.length ? (
 				<span className="woocommerce-search-list__item-prefix">
 					{ getBreadcrumbsForDisplay( item.breadcrumbs ) }
 				</span>
@@ -69,7 +59,7 @@ export const SearchListItem = ( {
 		countLabel !== null &&
 		item.count !== undefined &&
 		item.count !== null;
-	const hasBreadcrumbs = !! item.breadcrumbs?.length;
+	const hasBreadcrumbs = !! item.breadcrumbs.length;
 	const hasChildren = !! item.children?.length;
 	const isExpanded = expandedPanelId === item.id;
 	const classes = classNames(

assets/js/editor-components/search-list-control/types.ts

@@ -35,7 +35,7 @@ export interface ListItemsProps
 }
 
 export type SearchListItem = {
-	breadcrumbs?: string[];
+	breadcrumbs: string[];
 	children?: SearchListItem[];
 	count: number;
 	id: string | number;