Fix various GitHub Actions warnings (#7573)

* Remove git checkout HEAD^2

* Add assertion to Cross-Sells e2e test

* Replace deprecated set-output calls

* bot: update checkstyle.xml

* Remove obsolete eslint-disable comment

* Change “actions/cache@v2” to “actions/cache@v3”

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: nielslange

.github/workflows/codeql-analysis.yml

@@ -36,11 +36,6 @@ jobs:
                   # a pull request then we can checkout the head.
                   fetch-depth: 2
 
-            # If this run was triggered by a pull request event, then checkout
-            # the head of the pull request instead of the merge commit.
-            - run: git checkout HEAD^2
-              if: ${{ github.event_name == 'pull_request' }}
-
             # Initializes the CodeQL tools for scanning.
             - name: Initialize CodeQL
               uses: github/codeql-action/init@v2

.github/workflows/php-coding-standards.yml

@@ -30,10 +30,11 @@ jobs:
 
             - name: Get Composer cache directory
               id: composer-cache
-              run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+              run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
 
             - name: Set up Composer caching
-              uses: actions/cache@v2
+              uses: actions/cache@v3
               env:
                   cache-name: cache-composer-dependencies
               with:

.github/workflows/php-js-e2e-tests.yml

@@ -44,8 +44,9 @@ jobs:
             - name: Get Composer Cache Directory
               id: composer-cache
               run: |
-                  echo "::set-output name=dir::$(composer config cache-files-dir)"
-            - uses: actions/cache@v2
+                  echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+            - uses: actions/cache@v3
               with:
                   path: ${{ steps.composer-cache.outputs.dir }}
                   key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -124,8 +125,8 @@ jobs:
             - name: Get Composer Cache Directory
               id: composer-cache
               run: |
-                  echo "::set-output name=dir::$(composer config cache-files-dir)"
-            - uses: actions/cache@v2
+                  echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+            - uses: actions/cache@v3
               with:
                   path: ${{ steps.composer-cache.outputs.dir }}
                   key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}

.github/workflows/typescript-monitoring.yml

@@ -13,7 +13,7 @@ jobs:
                   ref: ${{ github.event.pull_request.head.ref }}
 
             - name: Cache node modules
-              uses: actions/cache@v2
+              uses: actions/cache@v3
               env:
                   cache-name: cache-node-modules
               with:
@@ -51,7 +51,7 @@ jobs:
             - name: Check if the checklist.xml file is changed
               id: verify_diff
               run: |
-                  git diff --quiet checkstyle.xml || echo "::set-output name=is_different_checkstyle::true"
+                  git diff --quiet checkstyle.xml || echo "is_different_checkstyle=true" >> $GITHUB_OUTPUT
 
             - name: Commit the new checklist.xml file
               if: steps.verify_diff.outputs.is_different_checkstyle == 'true'

.github/workflows/unit-tests.yml

@@ -43,7 +43,7 @@ jobs:
             - name: Get Composer Cache Directory
               id: composer-cache
               run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
-            - uses: actions/cache@v2
+            - uses: actions/cache@v3
               with:
                   path: ${{ steps.composer-cache.outputs.dir }}
                   key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -100,7 +100,7 @@ jobs:
               run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
             - name: Set up Composer caching
-              uses: actions/cache@v2
+              uses: actions/cache@v3
               env:
                 cache-name: cache-composer-dependencies
               with:

tests/e2e/specs/shopper/cart-checkout/cart.test.js

@@ -105,7 +105,6 @@ describe( 'Shopper → Cart', () => {
 		await shopper.block.productIsInCart( SIMPLE_VIRTUAL_PRODUCT_NAME, 4 );
 	} );
 
-	// eslint-disable-next-line jest/expect-expect
 	it( 'User can see Cross-Sells products block', async () => {
 		await shopper.block.emptyCart();
 		await shopper.block.goToShop();
@@ -119,7 +118,9 @@ describe( 'Shopper → Cart', () => {
 		await page.waitForSelector(
 			'.wp-block-woocommerce-cart-line-items-block tr:nth-child(2)'
 		);
-		await shopper.block.productIsInCart( '32GB USB Stick', 1 );
+		await expect(
+			shopper.block.productIsInCart( '32GB USB Stick', 1 )
+		).toBeTruthy();
 	} );
 
 	it( 'User can proceed to checkout', async () => {