This repository was archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 215
Global Styles - Product Title - fix styles application #8662
Copy link
Copy link
Open
Labels
block-type: product elementsIssues related to Product Element blocks.Issues related to Product Element blocks.block-type: product-queryIssues related to/affecting all product-query variations.Issues related to/affecting all product-query variations.focus: global stylesIssues that involve styles/css/layout structure.Issues that involve styles/css/layout structure.team: Kirigami & Origamitype: bugThe issue/PR concerns a confirmed bug.The issue/PR concerns a confirmed bug.
Description
Steps to reproduce
- Go to Editor
- Add Products block
- Add Product Title block as an inner block if not already included
- Make sure "Make title a link" is enabled
- Open Global Styles and change the following styles:
Typography - Text
- Appearance
Expected: Assuming the Product Title is a link it should not influence it
Actual: Only italic is applied, font weight doesn't change
Typography - Links
- Font
Expected: Applied in editor and frontend
Actual: Applied only in editor (frontend doesn't reflect the change)
Typography - Headings
- Font
- Size
- Line height
Expected: Applied
Actual: Not applied - Appearance
Expected: Appearance is applied
Actual: Only italic is applied, font weight doesn't change
Colors - Headings
- Headings
Expected: Both background color and text color applies
Actual: Only background color works
- Check all of the above in Editor and Frontend!
- Styles composition may be fragile and the issue may evolve. Please check if block reacts to all the other Global Styles
- For items we are inheriting from Gutenberg that seem inconsistent and/or have room for improvement, we should raise an upstream Issue or PR and avoid making localized changes that bring inconsistency with Gutenberg.
- Reflect the newest state of styles support in the Spreadsheet after finishing this task
Note: Technically speaking the Product Title is a heading (H3 by default), so should react to Typography Headings settings. All the expected states above are based on this assumption, however if you think it should not work that way, please update the steps and/or consult with others.
Metadata
Metadata
Assignees
Labels
block-type: product elementsIssues related to Product Element blocks.Issues related to Product Element blocks.block-type: product-queryIssues related to/affecting all product-query variations.Issues related to/affecting all product-query variations.focus: global stylesIssues that involve styles/css/layout structure.Issues that involve styles/css/layout structure.team: Kirigami & Origamitype: bugThe issue/PR concerns a confirmed bug.The issue/PR concerns a confirmed bug.