This repository was archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 215
Global Styles - Product Rating - fix styles application #8663
Copy link
Copy link
Open
Labels
block-type: product elementsIssues related to Product Element blocks.Issues related to Product Element blocks.block-type: product-queryIssues related to/affecting all product-query variations.Issues related to/affecting all product-query variations.focus: global stylesIssues that involve styles/css/layout structure.Issues that involve styles/css/layout structure.team: Kirigami & Origamitype: bugThe issue/PR concerns a confirmed bug.The issue/PR concerns a confirmed bug.
Description
Prerequisites
- Make sure to have at least one product with and one product without rating
Steps to reproduce
- Go to Editor
- Add Products block
- Add Product Rating block as an inner block if not already included
- Open Global Styles and change following styles:
Typography
-
Font
Expected: "Add review" changes the font
Actual:"Add review" reacts in the editor, but not in the fronted -
Size
Expected: "Add review" should keep the chosen size and can have a different size than Stars
Actual:"Add review" changes size in Editor, but on the frontend has the size of Stars -
Line height
Expected: "Add review" should keep the chosen line height and can have a different line height than Stars
Actual:"Add review" doesn't react to line height changes
- Check all of the above in Editor and Frontend!
- Styles composition may be fragile and the issue may evolve. Please check if block reacts to all the other Global Styles
- For items we are inheriting from Gutenberg that seem inconsistent and/or have room for improvement, we should raise an upstream Issue or PR and avoid making localized changes that bring inconsistency with Gutenberg.
- Reflect the newest state of styles support in the Spreadsheet after finishing this task
Note: Product Rating consists of
- Stars if there's a rating
- "Add review" link if there's no rating
Metadata
Metadata
Assignees
Labels
block-type: product elementsIssues related to Product Element blocks.Issues related to Product Element blocks.block-type: product-queryIssues related to/affecting all product-query variations.Issues related to/affecting all product-query variations.focus: global stylesIssues that involve styles/css/layout structure.Issues that involve styles/css/layout structure.team: Kirigami & Origamitype: bugThe issue/PR concerns a confirmed bug.The issue/PR concerns a confirmed bug.