This repository was archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 215
Global Styles - On Sale Badge - fix styles application #8665
Copy link
Copy link
Open
Labels
block-type: product elementsIssues related to Product Element blocks.Issues related to Product Element blocks.block-type: product-queryIssues related to/affecting all product-query variations.Issues related to/affecting all product-query variations.focus: global stylesIssues that involve styles/css/layout structure.Issues that involve styles/css/layout structure.team: Kirigami & Origamitype: bugThe issue/PR concerns a confirmed bug.The issue/PR concerns a confirmed bug.
Description
Prerequisites:
- Make sure to have at least one product on sale
Steps to reproduce
- Go to Editor
- Add Products block
- Add On Sale Badge block as an inner block if not already included
- Open Global Styles and change following styles:
Typography - Text
- Appearance
Expected: Font weight and italic are applied to "Sale" badge
Actual: Only italic is applied, font weight doesn't change - Verify all the other properties work as expected
Colors
- Text
Expected: "Sale" badge changes color
Actual: It doesn't react
- Check all of the above in Editor and Frontend!
- Styles composition may be fragile and the issue may evolve. Please check if block reacts to all the other Global Styles
- For items we are inheriting from Gutenberg that seem inconsistent and/or have room for improvement, we should raise an upstream Issue or PR and avoid making localized changes that bring inconsistency with Gutenberg.
- Reflect the newest state of styles support in the Spreadsheet after finishing this task
Metadata
Metadata
Assignees
Labels
block-type: product elementsIssues related to Product Element blocks.Issues related to Product Element blocks.block-type: product-queryIssues related to/affecting all product-query variations.Issues related to/affecting all product-query variations.focus: global stylesIssues that involve styles/css/layout structure.Issues that involve styles/css/layout structure.team: Kirigami & Origamitype: bugThe issue/PR concerns a confirmed bug.The issue/PR concerns a confirmed bug.