Refactor error handling in ApiClient and remove unused OrderEventsTracker dependency from FraudProtectionController

This update modifies the error handling in the `ApiClient` class to return a `WP_Error` when the blog ID is not found, improving clarity. Additionally, the `OrderEventsTracker` dependency has been removed from the `FraudProtectionController`, streamlining the class and eliminating unnecessary code.

Author: leonardola

src/ApiClient.php

@@ -279,18 +279,17 @@ private function make_request( string $method, string $path, string $session_id,
 		}
 
 		if ( ! $this->get_blog_id() ) {
-			FraudProtectionController::log(
-				'error',
-				'Jetpack blog ID not found. Is the site connected to WordPress.com? Failing open with "allow" decision.'
+			return new \WP_Error(
+				'blog_id_not_found',
+				'Jetpack blog ID not found'
 			);
-			return self::DECISION_ALLOW;
 		}
 
 		$body = \wp_json_encode(
 			array_merge(
 				$payload,
 				array(
-					'session_id'  => $session_id,
+					'session_id' => $session_id,
 				)
 			)
 		);

src/FraudProtectionController.php

@@ -90,13 +90,6 @@ class FraudProtectionController /* implements RegisterHooksInterface */ {
 	 */
 	private SessionVerifier $session_verifier;
 
-	/**
-	 * Order events tracker instance.
-	 *
-	 * @var OrderEventsTracker
-	 */
-	private OrderEventsTracker $order_events_tracker;
-
 	/**
 	 * Session blocking handler instance.
 	 *
@@ -130,7 +123,6 @@ public function register(): void {
 	 * @param PaymentMethodEventTracker  $payment_method_event_tracker The instance of PaymentMethodEventTracker to use.
 	 * @param SessionBlockingHandler     $session_blocking_handler     The instance of SessionBlockingHandler to use.
 	 * @param SessionVerifier            $session_verifier             The instance of SessionVerifier to use.
-	 * @param OrderEventsTracker         $order_events_tracker         The instance of OrderEventsTracker to use.
 	 * @param BlocksCheckoutProtector    $blocks_checkout_protector    The instance of BlocksCheckoutProtector to use.
 	 * @param ShortcodeCheckoutProtector $shortcode_checkout_protector The instance of ShortcodeCheckoutProtector to use.
 	 * @param AddPaymentMethodProtector  $add_payment_method_protector The instance of AddPaymentMethodProtector to use.
@@ -145,7 +137,6 @@ final public function init(
 		PaymentMethodEventTracker $payment_method_event_tracker,
 		SessionBlockingHandler $session_blocking_handler,
 		SessionVerifier $session_verifier,
-		OrderEventsTracker $order_events_tracker,
 		BlocksCheckoutProtector $blocks_checkout_protector,
 		ShortcodeCheckoutProtector $shortcode_checkout_protector,
 		AddPaymentMethodProtector $add_payment_method_protector,
@@ -159,7 +150,6 @@ final public function init(
 		$this->payment_method_event_tracker = $payment_method_event_tracker;
 		$this->session_blocking_handler     = $session_blocking_handler;
 		$this->session_verifier             = $session_verifier;
-		$this->order_events_tracker         = $order_events_tracker;
 		$this->blocks_checkout_protector    = $blocks_checkout_protector;
 		$this->shortcode_checkout_protector = $shortcode_checkout_protector;
 		$this->add_payment_method_protector = $add_payment_method_protector;
@@ -181,7 +171,6 @@ public function on_init(): void {
 		$this->blocked_session_notice->register();
 		$this->blackbox_script_handler->register();
 		$this->session_verifier->register();
-		$this->order_events_tracker->register();
 		$this->blocks_checkout_protector->register();
 		$this->shortcode_checkout_protector->register();
 		$this->add_payment_method_protector->register();

woocommerce-fraud-protection.php

@@ -123,7 +123,6 @@ function () {
 			$payment_method_event_tracker,
 			$session_blocking_handler,
 			$session_verifier,
-			$order_events_tracker,
 			$blocks_checkout_protector,
 			$shortcode_checkout_protector,
 			$add_payment_method_protector,