Using the new tax status constants (#4302)

* Using the new tax status constants

* Changelog and readme entries

* Changelog and readme updates

* Replacing occurrences in unit tests

Author: wjrosa

changelog.txt

@@ -1,6 +1,7 @@
 *** Changelog ***
 
 = 9.8.0 - xxxx-xx-xx =
+* Dev - Implements WooCommerce constants for the tax statuses
 * Add - Adds the current setting value for the Optimized Checkout to the Stripe System Status Report data
 * Add - A new pill to the payment methods page to indicate the credit card requirement when the Optimized Checkout feature is enabled
 * Add - Tracks the toggle of the Optimized Checkout feature in the promotional banner

includes/payment-methods/class-wc-stripe-express-checkout-helper.php

@@ -1,6 +1,7 @@
 <?php
 
 use Automattic\WooCommerce\Enums\ProductType;
+use Automattic\WooCommerce\Enums\ProductTaxStatus;
 
 if ( ! defined( 'ABSPATH' ) ) {
 	exit;
@@ -765,7 +766,7 @@ private function is_product_or_cart_taxable() {
 			if ( ! $product ) {
 				return false;
 			}
-			return $product->get_tax_status() !== 'none';
+			return $product->get_tax_status() !== ProductTaxStatus::NONE;
 		}
 
 		// Cart or checkout page: the cart is taxable if any item in the cart
@@ -782,7 +783,7 @@ private function is_product_or_cart_taxable() {
 				$cart_item_key
 			);
 
-			if ( 'none' !== $product->get_tax_status() ) {
+			if ( ProductTaxStatus::NONE !== $product->get_tax_status() ) {
 				return true;
 			}
 		}

readme.txt

@@ -111,6 +111,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 == Changelog ==
 
 = 9.8.0 - xxxx-xx-xx =
+* Dev - Implements WooCommerce constants for the tax statuses
 * Add - Adds the current setting value for the Optimized Checkout to the Stripe System Status Report data
 * Add - A new pill to the payment methods page to indicate the credit card requirement when the Optimized Checkout feature is enabled
 * Add - Tracks the toggle of the Optimized Checkout feature in the promotional banner

tests/phpunit/Helpers/WC_Helper_Product.php

@@ -2,6 +2,7 @@
 
 namespace WooCommerce\Stripe\Tests\Helpers;
 
+use Automattic\WooCommerce\Enums\ProductTaxStatus;
 use WC_Cache_Helper;
 use WC_Product_Attribute;
 use WC_Product_External;
@@ -50,7 +51,7 @@ public static function create_simple_product( $save = true, $props = [] ) {
 				'price'         => 10,
 				'sku'           => 'DUMMY SKU',
 				'manage_stock'  => false,
-				'tax_status'    => 'taxable',
+				'tax_status'    => ProductTaxStatus::TAXABLE,
 				'downloadable'  => false,
 				'virtual'       => false,
 				'stock_status'  => 'instock',

tests/phpunit/Helpers/WC_Helper_Shipping.php

@@ -2,6 +2,7 @@
 
 namespace WooCommerce\Stripe\Tests\Helpers;
 
+use Automattic\WooCommerce\Enums\ProductTaxStatus;
 use WC_Cache_Helper;
 
 /**
@@ -28,7 +29,7 @@ public static function create_simple_flat_rate( $cost = 10 ) {
 			'title'        => 'Flat rate',
 			'availability' => 'all',
 			'countries'    => '',
-			'tax_status'   => 'taxable',
+			'tax_status'   => ProductTaxStatus::TAXABLE,
 			'cost'         => $cost,
 		];
 

tests/phpunit/PaymentMethods/WC_Stripe_Express_Checkout_Helper_Test.php

@@ -2,6 +2,7 @@
 
 namespace WooCommerce\Stripe\Tests\PaymentMethods;
 
+use Automattic\WooCommerce\Enums\ProductTaxStatus;
 use WC_Gateway_Stripe;
 use WC_Stripe_UPE_Payment_Gateway;
 use WC_Gateway_Stripe_Alipay;
@@ -163,17 +164,17 @@ private function create_products_for_test_hides_ece_if_cannot_compute_taxes() {
 
 		$virtual_nontaxable_product = WC_Helper_Product::create_simple_product();
 		$virtual_nontaxable_product->set_virtual( true );
-		$virtual_nontaxable_product->set_tax_status( 'none' );
+		$virtual_nontaxable_product->set_tax_status( ProductTaxStatus::NONE );
 		$virtual_nontaxable_product->save();
 
 		$virtual_taxable_product = WC_Helper_Product::create_simple_product();
 		$virtual_taxable_product->set_virtual( true );
-		$virtual_taxable_product->set_tax_status( 'taxable' );
+		$virtual_taxable_product->set_tax_status( ProductTaxStatus::TAXABLE );
 		$virtual_taxable_product->save();
 
 		$shippable_taxable_product = WC_Helper_Product::create_simple_product();
 		$shippable_taxable_product->set_virtual( false );
-		$shippable_taxable_product->set_tax_status( 'taxable' );
+		$shippable_taxable_product->set_tax_status( ProductTaxStatus::TAXABLE );
 		$shippable_taxable_product->save();
 		$this->products = [
 			'virtual_nontaxable' => $virtual_nontaxable_product,
@@ -291,7 +292,7 @@ public function test_hides_ece_if_stripe_gateway_unavailable() {
 		// Add a non-taxable product to the cart.
 		$product = WC_Helper_Product::create_simple_product();
 		$product->set_virtual( false );
-		$product->set_tax_status( 'none' );
+		$product->set_tax_status( ProductTaxStatus::NONE );
 		$product->save();
 
 		WC()->session->init();