Capture off-session payments immediately so we can fetch charge information (#3281)

* Capture off-session payments immediately so we can fetch charge information

* Update unit tests

* Remove capture_method from the expected missing keys

* Add changelog entry

---------

Co-authored-by: Danae Millan <[email protected]>

Author: james-allan

changelog.txt

@@ -3,6 +3,7 @@
 = 8.5.2 - xxxx-xx-xx =
 * Fix - Fixed errors when using Link to purchase subscription products that could lead to duplicate payment attempts.
 * Fix - Prevent failures creating SetupIntents when using a non-saved payment method on the Legacy checkout experience.
+* Fix - Ensure immediate balance transaction assignment for subscription renewals by specifying capture_method => automatic in Stripe payment intents.
 * Dev - Bump L-2 versions for PHP tests.
 * Dev - Bump WordPress "tested up to" version to 6.6.
 

includes/abstracts/abstract-wc-stripe-payment-gateway.php

@@ -1754,6 +1754,7 @@ public function create_and_confirm_intent_for_off_session( $order, $prepared_sou
 			'off_session'          => 'true',
 			'confirm'              => 'true',
 			'confirmation_method'  => 'automatic',
+			'capture_method'       => 'automatic',
 		];
 
 		if ( isset( $full_request['statement_descriptor'] ) ) {

readme.txt

@@ -131,6 +131,7 @@ If you get stuck, you can ask for help in the Plugin Forum.
 = 8.5.2 - xxxx-xx-xx =
 * Fix - Fixed errors when using Link to purchase subscription products that could lead to duplicate payment attempts.
 * Fix - Prevent failures creating SetupIntents when using a non-saved payment method on the Legacy checkout experience.
+* Fix - Ensure immediate balance transaction assignment for subscription renewals by specifying capture_method => automatic in Stripe payment intents.
 * Dev - Bump L-2 versions for PHP tests.
 * Dev - Bump WordPress "tested up to" version to 6.6.
 

tests/phpunit/test-wc-stripe-sub-renewal.php

@@ -145,6 +145,7 @@ public function test_renewal_successful() {
 				'off_session'          => 'true',
 				'confirm'              => 'true',
 				'confirmation_method'  => 'automatic',
+				'capture_method'       => 'automatic',
 			];
 			foreach ( $expected_request_body_values as $key => $value ) {
 				$this->assertArrayHasKey( $key, $request_args['body'] );
@@ -184,7 +185,6 @@ public function test_renewal_successful() {
 			// Assert: the request body does not contains these keys.
 			$expected_missing_request_body_keys = [
 				'capture', // No need to capture with a payment intent.
-				'capture_method', // The default ('automatic') is what we want in this case, so we leave it off.
 				'expand[]',
 			];
 			foreach ( $expected_missing_request_body_keys as $key ) {