Removing SPE related code (deprecated name for OC) (#4449)

* Fix OC source of truth

* Fix tests

* Improving tests

* Improving tests

* Improving tests

* Improving tests

* Improving tests

* New helper to test OC related methods

* Remove unused import

* Renaming some variables to keep consistency

* Fix tests

* Changelog and reame entries

* Update changelog.txt

* Update readme.txt

* Removing SPE related code (deprecated name for OC)

* Updating docs

Author: wjrosa

client/blocks/upe/upe-deferred-intent-creation/payment-processor.js

@@ -333,7 +333,7 @@ const PaymentProcessor = ( {
 		} else {
 			removeCashAppLimitNotice();
 		}
-		// Apply single payment element styles if the selected payment method is card and SPE is enabled.
+		// Apply single payment element styles if the selected payment method is card and OC is enabled.
 		if ( getBlocksConfiguration()?.isOCEnabled ) {
 			applyStyles();
 

includes/class-wc-stripe-feature-flags.php

@@ -14,13 +14,6 @@ class WC_Stripe_Feature_Flags {
 	const LPM_BLIK_FEATURE_FLAG_NAME          = '_wcstripe_feature_lpm_blik';
 	const LPM_BECS_DEBIT_FEATURE_FLAG_NAME    = '_wcstripe_feature_lpm_becs_debit';
 
-	/**
-	 * Feature flag to control SPE (Single Payment Element, now OC - Optimized CHeckout) feature availability.
-	 *
-	 * @deprecated since 9.5.0 Use `WC_Stripe_Feature_Flags::OC_FEATURE_FLAG_NAME` instead.
-	 */
-	const SPE_FEATURE_FLAG_NAME = '_wcstripe_feature_spe';
-
 	/**
 	 * Map of feature flag option names => their default "yes"/"no" value.
 	 * This single source of truth makes it easier to maintain our dev tools.
@@ -176,18 +169,7 @@ public static function are_apms_deprecated() {
 	}
 
 	/**
-	 * Whether the Single Payment Element (SPE) feature flag is enabled.
-	 *
-	 * @return bool
-	 *
-	 * @deprecated since 9.5.0 Use `WC_Stripe_Feature_Flags::OC_FEATURE_FLAG_NAME` instead.
-	 */
-	public static function is_spe_available() {
-		return self::is_oc_available();
-	}
-
-	/**
-	 * Whether the Optimized Checkout (OC, previously known as SPE) feature flag is enabled.
+	 * Whether the Optimized Checkout (OC) feature flag is enabled.
 	 *
 	 * @return bool
 	 */

includes/payment-methods/class-wc-stripe-upe-payment-gateway.php

@@ -1966,18 +1966,7 @@ public function is_sepa_tokens_for_other_methods_enabled() {
 	}
 
 	/**
-	 * Checks if the Single Payment Element setting is enabled.
-	 *
-	 * @return bool Whether the Single Payment Element setting is enabled.
-	 *
-	 * @deprecated 9.5.0 Use is_oc_enabled() instead.
-	 */
-	public function is_spe_enabled() {
-		return $this->oc_enabled;
-	}
-
-	/**
-	 * Checks if the Optimized Checkout (previously known as SPE) setting is enabled.
+	 * Checks if the Optimized Checkout setting is enabled.
 	 *
 	 * @return bool Whether the Optimized Checkout setting is enabled.
 	 */

includes/payment-methods/class-wc-stripe-upe-payment-method.php

@@ -113,32 +113,14 @@ abstract class WC_Stripe_UPE_Payment_Method extends WC_Payment_Gateway {
 	protected $supports_deferred_intent;
 
 	/**
-	 * Whether Single Payment Element is enabled.
-	 *
-	 * @var bool
-	 *
-	 * @deprecated 9.5.0 Use `$oc_enabled` instead.
-	 */
-	protected $spe_enabled;
-
-	/**
-	 * Whether Optimized Checkout (previously known as SPE) is enabled.
+	 * Whether Optimized Checkout is enabled.
 	 *
 	 * @var bool
 	 */
 	protected $oc_enabled;
 
 	/**
-	 * The default title for the Single Payment Element.
-	 *
-	 * @var string
-	 *
-	 * @deprecated 9.5.0 Use `$oc_title` instead.
-	 */
-	protected $spe_title;
-
-	/**
-	 * The default title for the Optimized Checkout element (previously known as SPE).
+	 * The default title for the Optimized Checkout element
 	 *
 	 * @var string
 	 */

tests/phpunit/PaymentMethods/WC_Stripe_UPE_Payment_Method_Test.php

@@ -800,7 +800,7 @@ public function test_non_card_methods_are_not_available_when_optimized_checkout_
 		$stripe_settings                           = WC_Stripe_Helper::get_stripe_settings();
 		$stripe_settings['single_payment_element'] = 'yes';
 		WC_Stripe_Helper::update_main_stripe_settings( $stripe_settings );
-		update_option( WC_Stripe_Feature_Flags::SPE_FEATURE_FLAG_NAME, 'yes' );
+		update_option( WC_Stripe_Feature_Flags::OC_FEATURE_FLAG_NAME, 'yes' );
 
 		$mocked_methods = [
 			'get_capabilities_response',