Set order payment method title to the customisable title setting rather than the label (#3481)

* Use customisable title rather than label to set order's payment method title

* Add changelog entires

* Add unit test to verify custom payment method titles

* Remove tests which verify subscriptions

Author: james-allan

changelog.txt

@@ -24,6 +24,7 @@
 * Fix - Pre-orders set to pay upon release were remaining pending when attempting to pay using Stripe.
 * Fix - Ensure subscription renewal order statement descriptors include the order number suffix.
 * Fix - Resolved an issue which caused the WeChat Pay payment icon to not be displayed on shortcode checkout pages.
+* Fix - Set order payment method title to the customizable title setting rather than the default label.
 
 = 8.7.0 - 2024-09-16 =
 * Add - Introduces a new promotional surface to encourage merchants with the legacy checkout experience and APMs enabled to use the new checkout experience.

includes/payment-methods/class-wc-stripe-upe-payment-gateway.php

@@ -1618,7 +1618,7 @@ public function set_payment_method_title_for_order( $order, $payment_method_type
 			return;
 		}
 		$payment_method       = $this->payment_methods[ $payment_method_type ];
-		$payment_method_title = $payment_method->get_label();
+		$payment_method_title = $payment_method->get_title();
 		$payment_method_id    = $payment_method instanceof WC_Stripe_UPE_Payment_Method_CC ? $this->id : $payment_method->id;
 
 		$order->set_payment_method( $payment_method_id );

readme.txt

@@ -152,5 +152,6 @@ If you get stuck, you can ask for help in the Plugin Forum.
 * Fix - Pre-orders set to pay upon release were remaining pending when attempting to pay using Stripe.
 * Fix - Ensure subscription renewal order statement descriptors include the order number suffix.
 * Fix - Resolved an issue which caused the WeChat Pay payment icon to not be displayed on shortcode checkout pages.
+* Fix - Set order payment method title to the customizable title setting rather than the default label.
 
 [See changelog for all versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).

tests/phpunit/test-class-wc-stripe-upe-payment-gateway.php

@@ -2379,4 +2379,33 @@ public function test_set_payment_method_title_for_order() {
 		$this->assertEquals( 'stripe', $mock_subscription_0->get_payment_method() );
 		$this->assertEquals( 'stripe', $mock_subscription_0->get_payment_method() );
 	}
+
+	/**
+	 * Test test_set_payment_method_title_for_order with custom title.
+	 */
+	public function test_set_payment_method_title_for_order_custom_title() {
+		$order = WC_Helper_Order::create_order();
+
+		// CARD
+		// Set a custom title.
+		$payment_method_type     = WC_Stripe_UPE_Payment_Method_CC::STRIPE_ID;
+		$payment_method_settings = get_option( "woocommerce_stripe_{$payment_method_type}_settings", [] );
+		$payment_method_settings['title'] = 'Custom Card Title';
+		update_option( "woocommerce_stripe_{$payment_method_type}_settings", $payment_method_settings );
+
+		$this->mock_gateway->set_payment_method_title_for_order( $order, $payment_method_type );
+
+		$this->assertEquals( 'Custom Card Title', $order->get_payment_method_title() );
+
+		// SEPA
+		// Set a custom title.
+		$payment_method_type     = WC_Stripe_UPE_Payment_Method_Sepa::STRIPE_ID;
+		$payment_method_settings = get_option( "woocommerce_stripe_{$payment_method_type}_settings", [] );
+		$payment_method_settings['title'] = 'Custom SEPA Title';
+		update_option( "woocommerce_stripe_{$payment_method_type}_settings", $payment_method_settings );
+
+		$this->mock_gateway->set_payment_method_title_for_order( $order, $payment_method_type );
+
+		$this->assertEquals( 'Custom SEPA Title', $order->get_payment_method_title() );
+	}
 }