Undeprecate the PRB location filters (#2323)

* Undeprecate the PRB location filters

This commit undeprecates the following filters:

* wc_stripe_show_payment_request_on_cart
* wc_stripe_show_payment_request_on_checkout
* wc_stripe_hide_payment_request_on_product_page

The reason is to be found in #2099.

Author: Kristófer Reykjalín

changelog.txt

@@ -2,6 +2,7 @@
 
 = 6.3.0 - 2022-xx-xx =
 * Tweak - Remove html from translatable strings
+* Tweak - Revert the deprecation of the 'wc_stripe_hide_payment_request_on_product_page', 'wc_stripe_show_payment_request_on_checkout', and 'wc_stripe_show_payment_request_on_cart' filters.
 
 = 6.2.0 - 2022-02-17 =
 * Add - Add onboarding payment gateway setup methods.

includes/payment-methods/class-wc-stripe-payment-request.php

@@ -922,19 +922,11 @@ public function should_show_payment_request_button() {
 	 * @return  boolean  True if PRBs are enabled on the cart page, false otherwise
 	 */
 	public function should_show_prb_on_cart_page() {
-		// Message we show for the deprecated PRB location filters. Intended for support so we
-		// don't provide translations.
-		$deprecation_message      =
-			'Please configure Payment Request Button locations through the Stripe plugin settings.';
 		$should_show_on_cart_page = in_array( 'cart', $this->get_button_locations(), true );
 
-		// Respect the deprecated filters, but add a deprecation notice.
-		return apply_filters_deprecated(
+		return apply_filters(
 			'wc_stripe_show_payment_request_on_cart',
-			[ $should_show_on_cart_page ],
-			'5.5.0',
-			'', // There is no replacement.
-			$deprecation_message
+			$should_show_on_cart_page
 		);
 	}
 
@@ -949,19 +941,12 @@ public function should_show_prb_on_cart_page() {
 	public function should_show_prb_on_checkout_page() {
 		global $post;
 
-		// Message we show for the deprecated PRB location filters. Intended for support so we
-		// don't provide translations.
-		$deprecation_message          =
-			'Please configure Payment Request Button locations through the Stripe plugin settings.';
 		$should_show_on_checkout_page = in_array( 'checkout', $this->get_button_locations(), true );
 
-		// Respect the deprecated filters, but add a deprecation notice.
-		return apply_filters_deprecated(
+		return apply_filters(
 			'wc_stripe_show_payment_request_on_checkout',
-			[ $should_show_on_checkout_page, $post ],
-			'5.5.0',
-			'', // There is no replacement.
-			$deprecation_message
+			$should_show_on_checkout_page,
+			$post
 		);
 	}
 
@@ -976,20 +961,13 @@ public function should_show_prb_on_checkout_page() {
 	public function should_show_prb_on_product_pages() {
 		global $post;
 
-		// Message we show for the deprecated PRB location filters. Intended for support so we
-		// don't provide translations.
-		$deprecation_message         =
-			'Please configure Payment Request Button locations through the Stripe plugin settings.';
 		$should_show_on_product_page = in_array( 'product', $this->get_button_locations(), true );
 
-		// Respect the deprecated filters, but add a deprecation notice.
 		// Note the negation because if the filter returns `true` that means we should hide the PRB.
-		return ! apply_filters_deprecated(
+		return ! apply_filters(
 			'wc_stripe_hide_payment_request_on_product_page',
-			[ ! $should_show_on_product_page, $post ],
-			'5.5.0',
-			'', // There is no replacement.
-			$deprecation_message
+			! $should_show_on_product_page,
+			$post
 		);
 	}
 

readme.txt

@@ -129,5 +129,6 @@ If you get stuck, you can ask for help in the Plugin Forum.
 == Changelog ==
 
 = 6.3.0 - 2022-xx-xx =
+* Tweak - Revert the deprecation of the 'wc_stripe_hide_payment_request_on_product_page', 'wc_stripe_show_payment_request_on_checkout', and 'wc_stripe_show_payment_request_on_cart' filters.
 
 [See changelog for all versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).