Fix Uncaught TypeError: Argument 2 passed to WC_Stripe_API::detach_payment_method_from_customer() errors (#3334)

* Pull the source/payment method ID from the last error correctly

* change changelog entries

* Fix duplicate changelog entry

---------

Co-authored-by: Mayisha <[email protected]>

Author: james-allan

changelog.txt

@@ -21,6 +21,7 @@
 * Fix - Prevent displaying the default admin description on the checkout page when a payment method description is empty.
 * Fix - Adds back the ability to perform direct refunds for giropay orders via the order details page.
 * Fix - After configuring webhooks automatically ensure only the latest webhook endpoint is active, deleting duplicates configured manually.
+* Fix - Resolved PHP errors related to detaching payment methods after failed 3D-Secure challenges.
 * Tweak - Minor text updates to webhook-related configuration labels and buttons.
 * Tweak - Improve UX by using the 3DS verification modal to confirm setup intents for subscription sign-ups, ensuring customers stay on the checkout page.
 * Tweak - Display a notice when the Stripe connect URL is not available.

includes/class-wc-stripe-customer.php

@@ -540,7 +540,7 @@ public function get_payment_methods( $payment_method_type ) {
 	 * @param string $source_id
 	 */
 	public function delete_source( $source_id ) {
-		if ( ! $this->get_id() ) {
+		if ( empty( $source_id ) || ! $this->get_id() ) {
 			return false;
 		}
 

includes/class-wc-stripe-intent-controller.php

@@ -128,11 +128,23 @@ public function verify_intent() {
 			if ( isset( $_GET['save_payment_method'] ) && ! empty( $_GET['save_payment_method'] ) ) {
 				$intent = $gateway->get_intent_from_order( $order );
 				if ( isset( $intent->last_payment_error ) ) {
+					$last_payment_error = $intent->last_payment_error;
+					$source_id          = '';
+
+					// Backwards compatibility for payment intents that use sources.
+					if ( isset( $last_payment_error->payment_method->id ) ) {
+						$source_id = $last_payment_error->payment_method->id;
+					} elseif ( isset( $last_payment_error->source->id ) ) {
+						$source_id = $last_payment_error->source->id;
+					}
+
 					// Currently, Stripe saves the payment method even if the authentication fails for 3DS cards.
 					// Although, the card is not stored in DB we need to remove the source from the customer on Stripe
 					// in order to keep the sources in sync with the data in DB.
-					$customer = new WC_Stripe_Customer( wp_get_current_user()->ID );
-					$customer->delete_source( $intent->last_payment_error->source->id );
+					if ( ! empty( $source_id ) ) {
+						$customer = new WC_Stripe_Customer( wp_get_current_user()->ID );
+						$customer->delete_source( $source_id );
+					}
 				} else {
 					$metadata = $intent->metadata;
 					if ( isset( $metadata->save_payment_method ) && 'true' === $metadata->save_payment_method ) {

readme.txt

@@ -149,6 +149,7 @@ If you get stuck, you can ask for help in the Plugin Forum.
 * Fix - Prevent displaying the default admin description on the checkout page when a payment method description is empty.
 * Fix - Adds back the ability to perform direct refunds for giropay orders via the order details page.
 * Fix - After configuring webhooks automatically ensure only the latest webhook endpoint is active, deleting duplicates configured manually.
+* Fix - Resolved PHP errors related to detaching payment methods after failed 3D-Secure challenges.
 * Tweak - Minor text updates to webhook-related configuration labels and buttons.
 * Tweak - Improve UX by using the 3DS verification modal to confirm setup intents for subscription sign-ups, ensuring customers stay on the checkout page.
 * Tweak - Display a notice when the Stripe connect URL is not available.