Improve slow query for legacy subscriptions on WC status tools page by caching the data (#3848)

* cache the legacy sepa subscriptions order count to avoid frequent db calls

Author: Mayisha

changelog.txt

@@ -41,6 +41,7 @@
 * Fix - Improve the appearance of Stripe elements in checkout pages to match the store theme.
 * Fix - Hide ECE button for synced subscription variations.
 * Fix - Use the original shipping address for Amazon Pay pay for orders.
+* Tweak - Improve slow query for legacy SEPA subscriptions on WC status tools page by caching the data.
 * Tweak - Improve settings page load by delaying oauth URL generation.
 * Tweak - Update the Woo logo in the Configure connection modal
 

includes/migrations/class-wc-stripe-subscriptions-repairer-legacy-sepa-tokens.php

@@ -12,6 +12,8 @@
  */
 class WC_Stripe_Subscriptions_Repairer_Legacy_SEPA_Tokens extends WCS_Background_Repairer {
 
+	const LEGACY_SEPA_SUBSCRIPTIONS_COUNT = 'woocommerce_stripe_subscriptions_with_legacy_sepa';
+
 	/**
 	 * The transient key used to store the progress of the repair.
 	 *
@@ -341,6 +343,12 @@ public function add_debug_tool( $tools ) {
 	 * @return bool True if there are subscriptions using the Legacy SEPA payment method, false otherwise.
 	 */
 	private function has_legacy_sepa_subscriptions() {
+		$cached_legacy_sepa_subscriptions_count = get_transient( self::LEGACY_SEPA_SUBSCRIPTIONS_COUNT );
+
+		if ( false !== $cached_legacy_sepa_subscriptions_count ) {
+			return $cached_legacy_sepa_subscriptions_count > 0;
+		}
+
 		$subscriptions = wc_get_orders(
 			[
 				'return'         => 'ids',
@@ -350,8 +358,11 @@ private function has_legacy_sepa_subscriptions() {
 				'payment_method' => WC_Gateway_Stripe_Sepa::ID,
 			]
 		);
+		$subscriptions_count = count( $subscriptions );
+
+		set_transient( self::LEGACY_SEPA_SUBSCRIPTIONS_COUNT, $subscriptions_count, 12 * HOUR_IN_SECONDS );
 
-		return ! empty( $subscriptions );
+		return $subscriptions_count > 0;
 	}
 
 	/**

readme.txt

@@ -151,6 +151,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 * Fix - Improve the appearance of Stripe elements in checkout pages to match the store theme.
 * Fix - Hide ECE button for synced subscription variations.
 * Fix - Use the original shipping address for Amazon Pay pay for orders.
+* Tweak - Improve slow query for legacy SEPA subscriptions on WC status tools page by caching the data.
 * Tweak - Improve settings page load by delaying oauth URL generation.
 * Tweak - Update the Woo logo in the Configure connection modal