Fix Admin Notices faling tests (#4059)

* Add legacy_deprecation to the expected notices list if legacy checkout is enabled
* Hide legacy_deprecation notice when checking for valid key notices
* Update WC L, L-1 and L-2 versions for php tests
* Remove WP 6.5 from the support matrix

Author: diegocurbelo

.github/workflows/php-tests.yml

@@ -16,18 +16,20 @@ jobs:
         include:
           # WooCommerce
           - woocommerce_support_policy: L
-            woocommerce: '9.5.2'
+            woocommerce: '9.7.1'
           - woocommerce_support_policy: L-1
-            woocommerce: '9.3.4'
+            woocommerce: '9.6.2'
           - woocommerce_support_policy: L-2
-            woocommerce: '9.2.3'
+            woocommerce: '9.5.2'
           # WordPress
           - wordpress_support_policy: L
-            wordpress: '6.7'
+            wordpress: '6.7.2'
           - wordpress_support_policy: L-1
-            wordpress: '6.6'
+            wordpress: '6.6.2'
+          # WooCommerce 9.5.0+ requires WordPress 6.6+
+          # (we'll keep two versions from the 6.6 branch until Apr when WP 6.8 is released)
           - wordpress_support_policy: L-2
-            wordpress: '6.5'
+            wordpress: '6.6'
           # PHP
           - php_support_policy: L
             php: '8.1'

tests/phpunit/admin/test-wc-stripe-admin-notices.php

@@ -55,12 +55,16 @@ public function test_correct_stripe_notices_are_shown_in_all_scenarios( $options
 		$notices = new WC_Stripe_Admin_Notices();
 		ob_start();
 		$notices->admin_notices();
-		if ( WC_Stripe_Helper::is_wc_lt( WC_STRIPE_FUTURE_MIN_WC_VER ) ) {
-			// Displaying the style notice results in an early return.
-			if ( ! in_array( 'style', $expected_notices, true ) ) {
+		// Displaying the style notice results in an early return.
+		if ( ! in_array( 'style', $expected_notices, true ) ) {
+			if ( WC_Stripe_Helper::is_wc_lt( WC_STRIPE_FUTURE_MIN_WC_VER ) ) {
 				// This means a version support notice will be added.
 				$expected_notices[] = 'wcver';
 			}
+			if ( ! WC_Stripe_Feature_Flags::is_upe_checkout_enabled() ) {
+				// This means the legacy checkout support notice will be added.
+				$expected_notices[] = 'legacy_deprecation';
+			}
 		}
 
 		if ( $expected_output ) {
@@ -143,6 +147,7 @@ public function test_invalid_keys_notice_is_shown_when_account_data_is_not_valid
 		);
 		update_option( 'wc_stripe_show_style_notice', 'no' );
 		update_option( 'wc_stripe_show_sca_notice', 'no' );
+		update_option( 'wc_stripe_show_legacy_deprecation_notice', 'no' );
 		update_option( 'home', 'https://...' );
 
 		$notices = new WC_Stripe_Admin_Notices();