Checking for other BNPL plugins when showing the promotional banner (#4438)

* Checking for other BNPL plugins when showing the promotional banner

* Pass list of custom checkout fields

* Add the custom data under extensions

* Register the extended data and save it

* Defer logic to hook for consistency with normal checkout

* Add comments

* Add support for radio buttons

* Perform basic sanitization based on field type

* Add action for custom data validation

* Update action names

* Fix logic for getting standard checkout fields

* Add unit test

* Specify checkout form name

* Respect keys_only param even for block checkout

* Remove TODO and add comment

* Display all error messages instead of just the first.

Co-authored-by: Copilot <[email protected]>

* Add more comments

* Rename exception code

* Remove keys_only support

* Update changelog.txt

Co-authored-by: Diego Curbelo <[email protected]>

* Readme update

* Revert unrelated changes

* Revert unrelated changes

* Reaplying review suggestion + fix lint issues

---------

Co-authored-by: Anne Mirasol <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Diego Curbelo <[email protected]>

Author: 4 people

changelog.txt

@@ -1,6 +1,7 @@
 *** Changelog ***
 
 = 9.6.0 - xxxx-xx-xx =
+* Fix - Checks if the store has other BNPL extensions installed before displaying the promotional banner
 * Fix - Correctly notifies customers and merchants of a failed refund and reverts the refunded status
 * Update - Legacy checkout experience has been deprecated, new checkout experience is now the default for all sites
 * Fix - Fixes an edge case where the express payment method buttons would not be displayed on the checkout if taxes used to be enabled

client/settings/payment-settings/constants.js

@@ -3,3 +3,4 @@ export const NEW_CHECKOUT_EXPERIENCE_BANNER = 'new-checkout-experience';
 export const NEW_CHECKOUT_EXPERIENCE_APMS_BANNER =
 	'new-checkout-experience-apms';
 export const BNPL_PROMOTION_BANNER = 'bnpl_promotion_banner';
+export const BNPL_PROMOTION_BANNER_TARGET_VERSION = '9.7';

client/settings/payment-settings/promotional-banner/__tests__/get-promotional-banner-type.test.js

@@ -33,6 +33,7 @@ describe( 'getPromotionalBannerType', () => {
 	it( 'BNPL promotion banner', () => {
 		global.wc_stripe_settings_params = {
 			plugin_version: '9.7.0',
+			has_other_bnpl_plugins: false,
 		};
 
 		const accountData = {

client/settings/payment-settings/promotional-banner/get-promotional-banner-type.js

@@ -1,6 +1,7 @@
 /* global wc_stripe_settings_params */
 import {
 	BNPL_PROMOTION_BANNER,
+	BNPL_PROMOTION_BANNER_TARGET_VERSION,
 	NEW_CHECKOUT_EXPERIENCE_APMS_BANNER,
 	NEW_CHECKOUT_EXPERIENCE_BANNER,
 	RECONNECT_BANNER,
@@ -40,14 +41,16 @@ export const getPromotionalBannerType = (
 		isUpeEnabled &&
 		! hasBNPLEnabled &&
 		// eslint-disable-next-line camelcase
+		! wc_stripe_settings_params?.has_other_bnpl_plugins &&
+		// eslint-disable-next-line camelcase
 		wc_stripe_settings_params?.plugin_version &&
 		parseFloat(
 			// eslint-disable-next-line camelcase
 			String( wc_stripe_settings_params.plugin_version )
 				.split( '.' )
 				.slice( 0, 2 )
 				.join( '.' )
-		) >= 9.7
+		) >= BNPL_PROMOTION_BANNER_TARGET_VERSION
 	) {
 		return BNPL_PROMOTION_BANNER;
 	} else if ( ! isUpeEnabled ) {

includes/admin/class-wc-stripe-settings-controller.php

@@ -236,6 +236,15 @@ public function admin_scripts( $hook_suffix ) {
 			// Show the BNPL promotional banner only if no BNPL payment methods are enabled.
 			&& ! array_intersect( WC_Stripe_Payment_Methods::BNPL_PAYMENT_METHODS, $enabled_payment_methods );
 
+		$has_other_bnpl_plugins_active = false;
+		$available_payment_gateways    = WC()->payment_gateways->payment_gateways;
+		foreach ( $available_payment_gateways as $gateway ) {
+			if ( ( 'affirm' === $gateway->id || 'klarna_payments' === $gateway->id ) && 'yes' === $gateway->enabled ) {
+				$has_other_bnpl_plugins_active = true;
+				break;
+			}
+		}
+
 		$params = [
 			'time'                         => time(),
 			'i18n_out_of_sync'             => $message,
@@ -257,6 +266,7 @@ public function admin_scripts( $hook_suffix ) {
 			'is_oc_available'              => WC_Stripe_Feature_Flags::is_oc_available(),
 			'oauth_nonce'                  => wp_create_nonce( 'wc_stripe_get_oauth_urls' ),
 			'is_sepa_tokens_enabled'       => 'yes' === $this->gateway->get_option( 'sepa_tokens_for_other_methods', 'no' ),
+			'has_other_bnpl_plugins'       => $has_other_bnpl_plugins_active,
 		];
 		wp_localize_script(
 			'woocommerce_stripe_admin',

readme.txt

@@ -112,6 +112,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 
 = 9.6.0 - xxxx-xx-xx =
 
+* Fix - Checks if the store has other BNPL extensions installed before displaying the promotional banner
 * Fix - Correctly notifies customers and merchants of a failed refund and reverts the refunded status.
 * Update - Legacy checkout experience has been deprecated, new checkout experience is now the default for all sites
 * Fix - Fixes an edge case where the express payment method buttons would not be displayed on the checkout if taxes used to be enabled