Prevent PMC migration to run when the plugin is not connected to Stripe (#4593)

* Add is_connected check to PMC is_enabled method
* Update includes/class-wc-stripe-helper.php
* Udpate is_enabled() docblock

---------

Co-authored-by: daledupreez <[email protected]>

Author: diegocurbelo

changelog.txt

@@ -11,6 +11,7 @@
 * Fix - Relax customer validation that was preventing payments from the pay for order page
 * Fix - Remove connection type requirement from PMC sync migration attempt
 * Tweak - Small improvements to e2e tests
+* Fix - Prevent the PMC migration to run when the plugin is not connected to Stripe
 
 = 9.8.0 - 2025-08-11 =
 * Add - Adds the current setting value for the Optimized Checkout to the Stripe System Status Report data

includes/class-wc-stripe-helper.php

@@ -1983,4 +1983,24 @@ public static function validate_intent_for_order( $order, $intent, ?string $sele
 
 		throw new Exception( __( "We're not able to process this request. Please try again later.", 'woocommerce-gateway-stripe' ) );
 	}
+
+	/**
+	 * Determines if the store is connected to Stripe.
+	 *
+	 * @param string $mode Optional. The mode to check. 'live' or 'test' - if not provided, the currently enabled mode will be checked.
+	 * @return bool True if connected, false otherwise.
+	 */
+	public static function is_connected( $mode = null ) {
+		// If the mode is not provided, we'll check the current mode.
+		if ( null === $mode ) {
+			$mode = WC_Stripe_Mode::is_test() ? 'test' : 'live';
+		}
+
+		$options = self::get_stripe_settings();
+		if ( 'test' === $mode ) {
+			return isset( $options['test_publishable_key'], $options['test_secret_key'] ) && trim( $options['test_publishable_key'] ) && trim( $options['test_secret_key'] );
+		} else {
+			return isset( $options['publishable_key'], $options['secret_key'] ) && trim( $options['publishable_key'] ) && trim( $options['secret_key'] );
+		}
+	}
 }

includes/class-wc-stripe-payment-method-configurations.php

@@ -296,13 +296,16 @@ function ( $id ) use ( $is_test_mode ) {
 
 	/**
 	 * Check if the payment method configurations API can be used to store enabled payment methods.
-	 * This requires the Stripe account to be connected to our platform ('connection_type' option to be 'connect').
-	 *
-	 * This is temporary until we finish the re-authentication campaign.
+	 * This requires the Stripe account to be connected to Stripe.
 	 *
 	 * @return bool
 	 */
 	public static function is_enabled() {
+		// Bail if account is not connected.
+		if ( ! WC_Stripe_Helper::is_connected() ) {
+			return false;
+		}
+
 		$stripe_settings = WC_Stripe_Helper::get_stripe_settings();
 
 		// If we have the pmc_enabled flag, and it is set to no, we should not use the payment method configurations API.

includes/connect/class-wc-stripe-connect.php

@@ -269,17 +269,7 @@ private function get_default_stripe_config() {
 		 * @return bool True if connected, false otherwise.
 		 */
 		public function is_connected( $mode = null ) {
-			// If the mode is not provided, we'll check the current mode.
-			if ( is_null( $mode ) ) {
-				$mode = WC_Stripe_Mode::is_test() ? 'test' : 'live';
-			}
-
-			$options = WC_Stripe_Helper::get_stripe_settings();
-			if ( 'test' === $mode ) {
-				return isset( $options['test_publishable_key'], $options['test_secret_key'] ) && trim( $options['test_publishable_key'] ) && trim( $options['test_secret_key'] );
-			} else {
-				return isset( $options['publishable_key'], $options['secret_key'] ) && trim( $options['publishable_key'] ) && trim( $options['secret_key'] );
-			}
+			return WC_Stripe_Helper::is_connected( $mode );
 		}
 
 		/**

readme.txt

@@ -121,5 +121,6 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 * Fix - Relax customer validation that was preventing payments from the pay for order page
 * Fix - Remove connection type requirement from PMC sync migration attempt
 * Tweak - Small improvements to e2e tests
+* Fix - Prevent the PMC migration to run when the plugin is not connected to Stripe
 
 [See changelog for full details across versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).

tests/phpunit/Admin/Migrations/Migrate_Payment_Methods_From_DB_To_PMC_Test.php

@@ -24,8 +24,10 @@ public function set_up() {
 
 		$this->pmc = new WC_Stripe_Payment_Method_Configurations();
 
-		// Set up test connection type to enable PMC
+		// Set up test connection info to enable PMC
 		$stripe_settings = WC_Stripe_Helper::get_stripe_settings();
+		$stripe_settings['test_publishable_key'] = 'pk_test_1234567890';
+		$stripe_settings['test_secret_key']      = 'sk_test_1234567890';
 		$stripe_settings['test_connection_type'] = 'connect';
 		WC_Stripe_Helper::update_main_stripe_settings( $stripe_settings );
 	}

tests/phpunit/Admin/WC_Stripe_Settings_Controller_Test.php

@@ -77,6 +77,8 @@ public function test_admin_options_when_stripe_is_not_connected() {
 		$stripe_settings['testmode']             = 'yes';
 		$stripe_settings['test_publishable_key'] = '';
 		$stripe_settings['test_secret_key']      = '';
+		$stripe_settings['publishable_key']      = '';
+		$stripe_settings['secret_key']           = '';
 		WC_Stripe_Helper::update_main_stripe_settings( $stripe_settings );
 
 		ob_start();

tests/phpunit/Helpers/UPE_Test_Helper.php

@@ -48,7 +48,11 @@ function () {
 		WC()->payment_gateways()->payment_gateways = [];
 		WC()->payment_gateways()->init();
 		$settings                         = WC_Stripe_Helper::get_stripe_settings();
+		$settings['publishable_key']      = 'pk_live_1234567890';
+		$settings['secret_key']           = 'sk_live_1234567890';
 		$settings['connection_type']      = 'connect';
+		$settings['test_publishable_key'] = 'pk_test_1234567890';
+		$settings['test_secret_key']      = 'sk_test_1234567890';
 		$settings['test_connection_type'] = 'connect';
 		$settings['pmc_enabled']          = 'yes';
 		WC_Stripe_Helper::update_main_stripe_settings( $settings );

tests/phpunit/PaymentMethods/WC_Stripe_UPE_Payment_Method_Test.php

@@ -931,6 +931,8 @@ public function test_update_payment_token() {
 	public function test_upe_method_enabled() {
 		$stripe_settings                         = WC_Stripe_Helper::get_stripe_settings();
 		$stripe_settings['enabled']              = 'yes';
+		$stripe_settings['test_publishable_key'] = 'pk_test_1234567890';
+		$stripe_settings['test_secret_key']      = 'sk_test_1234567890';
 		$stripe_settings['test_connection_type'] = 'connect';
 		$stripe_settings['pmc_enabled']          = 'yes';
 		WC_Stripe_Helper::update_main_stripe_settings( $stripe_settings );

tests/phpunit/WC_REST_Stripe_Account_Keys_Controller_Test.php

@@ -42,7 +42,9 @@ public function set_up() {
 		// Setup existing keys
 		$settings                         = WC_Stripe_Helper::get_stripe_settings();
 		$settings['publishable_key']      = 'original-live-key-9999';
+		$settings['secret_key']           = '';
 		$settings['test_publishable_key'] = 'original-test-key-9999';
+		$settings['test_secret_key']      = '';
 		WC_Stripe_Helper::update_main_stripe_settings( $settings );
 
 		$mock_account = $this->getMockBuilder( WC_Stripe_Account::class )
@@ -176,7 +178,7 @@ public function test_changing_keys_resets_payment_methods() {
 
 		// Build request params
 		$request = new WP_REST_Request( 'POST', self::ROUTE );
-		$request->set_param( 'publishable_key', '' );
+		$request->set_param( 'publishable_key', 'pk_live-key-updated' );
 
 		// Set initial payment methods
 		$this->set_stripe_account_data( [ 'country' => 'US' ] );