Removing the detached subscriptions notice feature (#4320)

* Removing the detached subscriptions notice feature

* Changelog and readme entries

* Adding the deprecation function to methods

* Update changelog.txt

Co-authored-by: daledupreez <[email protected]>

* Readme entry update

---------

Co-authored-by: daledupreez <[email protected]>

Author: wjrosa

changelog.txt

@@ -1,6 +1,7 @@
 *** Changelog ***
 
 = 9.5.1 - xxxx-xx-xx =
+* Fix - Stop checking for detached subscriptions for admin users, as it was slowing down wp-admin
 * Fix - Fix fatal error when checking for a payment method availability using a specific order ID.
 
 = 9.5.0 - 2025-05-13 =

includes/admin/class-wc-stripe-admin-notices.php

@@ -66,11 +66,6 @@ public function admin_notices() {
 		// All other payment methods.
 		$this->payment_methods_check_environment();
 
-		// Subscription related checks.
-		if ( WC_Stripe_Subscriptions_Helper::is_subscriptions_enabled() ) {
-			$this->subscriptions_check_environment();
-		}
-
 		foreach ( (array) $this->notices as $notice_key => $notice ) {
 			echo '<div class="' . esc_attr( $notice['class'] ) . '" style="position:relative;">';
 
@@ -467,8 +462,11 @@ public function payment_methods_check_environment() {
 	 * Environment check for subscriptions.
 	 *
 	 * @return void
+	 *
+	 * @deprecated 9.6.0 This method is no longer used and will be removed in a future version.
 	 */
 	public function subscriptions_check_environment() {
+		_deprecated_function( __METHOD__, '9.6.0' );
 		$options = WC_Stripe_Helper::get_stripe_settings();
 		if ( 'yes' === ( $options['enabled'] ?? null ) && 'no' !== get_option( 'wc_stripe_show_subscriptions_notice' ) ) {
 			$subscriptions     = WC_Stripe_Subscriptions_Helper::get_some_detached_subscriptions();

includes/compat/class-wc-stripe-subscriptions-helper.php

@@ -27,8 +27,11 @@ public static function is_subscriptions_enabled() {
 	 * Loads up to 50 subscriptions, and attempts to return up to 5 of those that are detached from the customer.
 	 *
 	 * @return array
+	 *
+	 * @deprecated 9.6.0 This method is no longer used and will be removed in a future version.
 	 */
 	public static function get_some_detached_subscriptions() {
+		_deprecated_function( __METHOD__, '9.6.0' );
 		// Check if we have a cached result.
 		$cached_subscriptions = get_transient( self::DETACHED_SUBSCRIPTIONS_TRANSIENT_KEY );
 		if ( ! empty( $cached_subscriptions ) ) {

readme.txt

@@ -111,6 +111,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 == Changelog ==
 
 = 9.5.1 - xxxx-xx-xx =
+* Fix - Stop checking for detached subscriptions for admin users, as it was slowing down wp-admin
 * Fix - Fix fatal error when checking for a payment method availability using a specific order ID.
 
 [See changelog for full details across versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).

tests/phpunit/compat/test-class-wc-stripe-subscriptions-helper.php

@@ -17,55 +17,4 @@ class WC_Stripe_Subscriptions_Helper_Test extends WP_UnitTestCase {
 	public function test_is_subscriptions_enabled() {
 		$this->assertTrue( WC_Stripe_Subscriptions_Helper::is_subscriptions_enabled() );
 	}
-
-	/**
-	 * Test for `get_some_detached_subscriptions`.
-	 *
-	 * @return void
-	 */
-	public function test_get_some_detached_subscriptions() {
-		$subscription_id = 1;
-		$customer_id     = 'cus_123';
-		$source_id       = 'src_123';
-
-		$subscription = new WC_Subscription();
-		$subscription->set_id( $subscription_id );
-		$subscription->set_status( 'active' );
-		$subscription->save();
-
-		$subscription->update_meta_data( '_stripe_customer_id', $customer_id );
-		$subscription->update_meta_data( '_stripe_source_id', $source_id );
-		$subscription->save_meta_data();
-
-		WC_Subscriptions_Helpers::$wcs_get_subscriptions = [ $subscription ];
-
-		// Mock response from Stripe API.
-		$test_request = function () {
-			return [
-				'response' => 200,
-				'headers'  => [ 'Content-Type' => 'application/json' ],
-				'body'     => wp_json_encode(
-					[
-						'customer' => null,
-					]
-				),
-			];
-		};
-
-		add_filter( 'pre_http_request', $test_request, 10, 3 );
-
-		$expected = [
-			[
-				'id'                        => $subscription_id,
-				'customer_id'               => $customer_id,
-				'change_payment_method_url' => $subscription->get_change_payment_method_url(),
-			],
-		];
-		$this->assertEquals( $expected, WC_Stripe_Subscriptions_Helper::get_some_detached_subscriptions() );
-
-		remove_filter( 'pre_http_request', $test_request, 10, 3 );
-
-		// Test cached version
-		$this->assertEquals( $expected, WC_Stripe_Subscriptions_Helper::get_some_detached_subscriptions() );
-	}
 }