Merge remote-tracking branch 'origin/release/9.1.0' into trunk

Author: wjrosa

.github/workflows/compatibility.yml

@@ -24,7 +24,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Set up dependencies caching
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.cache/composer/
           key:  ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}

.github/workflows/js-tests.yml

@@ -15,7 +15,7 @@ jobs:
         with:
           node-version-file: '.nvmrc'
       # enable dependencies caching
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.npm/
           key:  ${{ runner.os }}-npm-${{ hashFiles('package-lock.json') }}

.github/workflows/linting.yml

@@ -15,7 +15,7 @@ jobs:
       # clone the repository
       - uses: actions/checkout@v2
       # enable dependencies caching
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.cache/composer/
           key:  ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}
@@ -38,11 +38,11 @@ jobs:
         with:
           node-version-file: '.nvmrc'
       # enable dependencies caching
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.cache/composer/
           key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.npm/
           key: ${{ runner.os }}-npm-${{ hashFiles('package-lock.json') }}

.github/workflows/php-tests.yml

@@ -46,7 +46,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Set up dependencies caching
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.cache/composer/
           key:  ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}

.github/workflows/qit-e2e-tests.yml

@@ -0,0 +1,104 @@
+name: QIT E2E tests
+
+on:
+  pull_request
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      max-parallel: 10
+      matrix:
+        checkout: [ 'Default', 'Legacy' ]
+
+    name: ${{ matrix.checkout }} QIT E2E tests
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v4
+
+      # PHP
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 7.4
+          tools: composer
+          coverage: none
+
+      - name: Cache Composer deps
+        id: composer-cache
+        uses: actions/cache@v4
+        with:
+          path: ./vendor
+          key: ${{ runner.os }}-vendor-${{ hashFiles('composer.lock') }}
+
+      - name: Install composer dependencies
+        if: ${{ steps.composer-cache.outputs.cache-hit == false }}
+        shell: bash
+        run: composer install --no-progress
+
+      # Node
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+
+      - name: Cache Node deps
+        id: node-cache
+        uses: actions/cache@v4
+        with:
+          path: |
+            ./node_modules
+            ~/.cache/ms-playwright
+          key: ${{ runner.os }}-node_modules-${{ hashFiles('package-lock.json') }}
+
+      - name: Install node dependencies
+        if: ${{ steps.node-cache.outputs.cache-hit == false }}
+        shell: bash
+        run: npm ci
+
+      # Build
+      - name: Build plugin package
+        shell: bash
+        run: |
+          npm run build
+
+      # QIT CLI
+      - name: Install QIT via composer
+        run: composer require woocommerce/qit-cli --dev
+      
+      - name: Add partner for QIT
+        run: ./vendor/bin/qit partner:add --user='${{ secrets.PARTNER_USER }}' --application_password='${{ secrets.PARTNER_SECRET }}'
+
+      # E2E test environment
+      - name: Fill in .env
+        run: |
+          echo 'STRIPE_PUB_KEY="${{ secrets.E2E_STRIPE_PUBLISHABLE_KEY }}"' >> .env
+          echo 'STRIPE_SECRET_KEY="${{ secrets.E2E_STRIPE_SECRET_KEY }}"' >> .env
+          echo 'PAYPAL_MERCHANT_ID="${{ secrets.PAYPAL_MERCHANT_ID }}"' >> .env
+          echo 'PAYPAL_MERCHANT_EMAIL="${{ secrets.PAYPAL_MERCHANT_EMAIL }}"' >> .env
+          echo 'PAYPAL_CLIENT_ID="${{ secrets.PAYPAL_CLIENT_ID }}"' >> .env
+          echo 'PAYPAL_CLIENT_SECRET="${{ secrets.PAYPAL_CLIENT_SECRET }}"' >> .env
+          echo 'PAYPAL_CUSTOMER_EMAIL="${{ secrets.PAYPAL_CUSTOMER_EMAIL }}"' >> .env
+          echo 'PAYPAL_CUSTOMER_PASSWORD="${{ secrets.PAYPAL_CUSTOMER_PASSWORD }}"' >> .env
+
+      - name: Run ${{ matrix.checkout }} E2E tests
+        shell: bash
+        run: ./vendor/bin/qit run:e2e woocommerce-gateway-stripe ${{ matrix.checkout == 'Legacy' && 'legacy' || '' }} --source ./ --plugin woocommerce --plugin woocommerce-subscriptions --plugin woocommerce-paypal-payments:test:setup-tests --env_file .env
+      
+      - name: Set the path in an env var
+        if: ${{ failure() }}
+        run: echo "E2E_REPORT_PATH=$(./vendor/bin/qit e2e-report --dir_only --local)/playwright" >> $GITHUB_ENV
+
+      - name: Upload ${{ matrix.checkout }} QIT E2E test results
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ matrix.checkout }}-qit-e2e-test-results
+          path: ${{ env.E2E_REPORT_PATH }}
+          if-no-files-found: ignore
+          retention-days: 14

assets/js/stripe.js

@@ -1,6 +1,12 @@
 /* global wc_stripe_params, Stripe */
 
-jQuery( function( $ ) {
+import {
+	PAYMENT_METHOD_BOLETO,
+	PAYMENT_METHOD_OXXO,
+	PAYMENT_METHOD_SEPA,
+} from 'wcstripe/stripe-utils/constants';
+
+jQuery( function($ ) {
 	'use strict';
 
 	try {
@@ -538,7 +544,7 @@ jQuery( function( $ ) {
 			if ( wc_stripe_form.isSepaChosen() ) {
 				extra_details.currency = $( '#stripe-sepa_debit-payment-data' ).data( 'currency' );
 				extra_details.mandate  = { notification_method: wc_stripe_params.sepa_mandate_notification };
-				extra_details.type     = 'sepa_debit';
+				extra_details.type     = PAYMENT_METHOD_SEPA;
 
 				return stripe.createSource( iban, extra_details ).then( wc_stripe_form.sourceResponse );
 			}
@@ -695,7 +701,7 @@ jQuery( function( $ ) {
 		 * After the customer closes the modal proceeds with checkout normally
 		 */
 		handleBoleto: function () {
-			wc_stripe_form.executeCheckout( 'boleto', function ( checkout_response ) {
+			wc_stripe_form.executeCheckout( PAYMENT_METHOD_BOLETO, function ( checkout_response ) {
 				stripe.confirmBoletoPayment(
 					checkout_response.client_secret,
 					checkout_response.confirm_payment_data
@@ -779,7 +785,7 @@ jQuery( function( $ ) {
 		 * After the customer closes the modal proceeds with checkout normally
 		 */
 		handleOxxo: function () {
-			wc_stripe_form.executeCheckout( 'oxxo', function ( checkout_response ) {
+			wc_stripe_form.executeCheckout( PAYMENT_METHOD_OXXO, function ( checkout_response ) {
 				stripe.confirmOxxoPayment(
 					checkout_response.client_secret,
 					checkout_response.confirm_payment_data

changelog.txt

@@ -1,5 +1,41 @@
 *** Changelog ***
 
+= 9.1.0 - 2025-01-09 =
+* Fix - Fixes the new checkout experience not being enabled by default due to conflict with a migration.
+* Fix - Prevents duplicated credit cards to be added to the customer's account through the My Account page, the shortcode checkout and the block checkout.
+* Fix - Return to the correct page when redirect-based payment method fails.
+* Fix - Show default recipient for Payment Authentication Requested email.
+* Fix - Correctly handles IPP failed payments webhook calls by extracting the order ID from the payment intent metadata.
+* Fix - Fix ECE crash in classic cart and checkout pages for non-English language sites.
+* Fix - Correctly handles UK postcodes redacted by Apple Pay.
+* Tweak - Avoid re-sending Processing Order customer email when merchant wins dispute.
+* Fix - Allow the saving of iDEAL tokens when SEPA is disabled.
+* Fix - Fixes the incompatibility notice in editor due missing style property when instantiating Stripe payment methods.
+* Dev - Updates the GitHub caching action (`actions/cache`) to v4 due deprecation.
+* Fix - Don't update canceled order status to on-hold when a dispute is opened.
+* Fix - Correctly sets the dispute opened note when a dispute does not require any further action.
+* Add - Display Multibanco payment instruction details in Order Received page and Order Confirmation email.
+* Tweak - Add the transaction limit information to the Afterpay/Clearpay method when listing payment methods.
+* Tweak - Add transaction threshold information to Affirm when listing payment methods.
+* Fix - Handles additional fields when checking out using ECE on the block checkout.
+* Dev - Introduces new payment method name constants for the frontend.
+* Dev - Improves the missing intent params error log by appending the payment information array.
+* Tweak - Improve error message displayed when payment method creation fails in classic checkout.
+* Tweak - Display email address for Link saved payment methods.
+* Fix - Only update order status for a Radar review closed event when the order was already captured.
+* Dev - Introduces a new class with payment intent statuses constants.
+* Add - Correctly handles charge expired webhook events, setting the order status to failed and adding a note.
+* Fix - Allow account creation on checkout, if enabled, when purchasing subscriptions using ECE.
+* Tweak - Add empty check for cart when checking for allowed products for express checkout.
+* Tweak - Improve webhook status related messages on the settings page.
+* Update - Prevent editing of orders awaiting payment capture.
+* Add - Introduce locking and unlocking in refund flow to prevent double refund due to race condition.
+* Dev - Add a GitHub Action workflow to run QIT E2E Integrations tests.
+* Fix - Check billing interval and period to set in mandate options.
+* Fix - Check order currency on pay for order page to display supported payment methods.
+* Update - Migrate payment request settings data to express checkout settings data.
+* Update - Make the new Stripe Express Checkout Element enabled by default in all accounts.
+
 = 9.0.0 - 2024-12-12 =
 * Fix - Fix 404 that happens when using ECE and 3D Secure auth is triggered.
 * Fix - Set correct payment method when using Link and a card that is 3D Secure authenticated.

client/api/index.js

@@ -5,6 +5,7 @@ import {
 	getExpressCheckoutAjaxURL,
 	getRequiredFieldDataFromCheckoutForm,
 } from 'wcstripe/express-checkout/utils';
+import { PAYMENT_METHOD_CASHAPP } from 'wcstripe/stripe-utils/constants';
 
 /**
  * Handles generic connections to the server and Stripe.
@@ -195,7 +196,7 @@ export default class WCStripeAPI {
 				return response.data.next_action.type;
 			}
 
-			if ( response.data.payment_type === 'cashapp' ) {
+			if ( response.data.payment_type === PAYMENT_METHOD_CASHAPP ) {
 				// Cash App Payments.
 				const returnURL = decodeURIComponent(
 					response.data.return_url

client/blocks/credit-card/index.js

@@ -39,6 +39,15 @@ const StripeLabel = ( props ) => {
 };
 
 const cardIcons = getStripeCreditCardIcons();
+const supports = {
+	// Use `false` as fallback values in case server provided configuration is missing.
+	showSavedCards: getBlocksConfiguration()?.showSavedCards ?? false,
+	showSaveOption: getBlocksConfiguration()?.showSaveOption ?? false,
+	features: getBlocksConfiguration()?.supports ?? [],
+};
+if ( getBlocksConfiguration().isAdmin ?? false ) {
+	supports.style = getBlocksConfiguration()?.style ?? [];
+}
 const stripeCcPaymentMethod = {
 	name: PAYMENT_METHOD_NAME,
 	label: <StripeLabel />,
@@ -53,12 +62,7 @@ const stripeCcPaymentMethod = {
 		'Stripe Credit Card payment method',
 		'woocommerce-gateway-stripe'
 	),
-	supports: {
-		// Use `false` as fallback values in case server provided configuration is missing.
-		showSavedCards: getBlocksConfiguration()?.showSavedCards ?? false,
-		showSaveOption: getBlocksConfiguration()?.showSaveOption ?? false,
-		features: getBlocksConfiguration()?.supports ?? [],
-	},
+	supports,
 };
 
 export default stripeCcPaymentMethod;

client/blocks/credit-card/use-payment-processing.js

@@ -5,7 +5,7 @@ import {
 	useElements,
 } from '@stripe/react-stripe-js';
 import { getErrorMessageForTypeAndCode } from '../../stripe-utils';
-import { errorTypes } from '../../stripe-utils/constants';
+import { errorTypes, PAYMENT_METHOD_CARD } from '../../stripe-utils/constants';
 import { PAYMENT_METHOD_NAME } from './constants';
 import { getBlocksConfiguration } from 'wcstripe/blocks/utils';
 
@@ -56,7 +56,7 @@ export const usePaymentProcessing = (
 					: CardNumberElement;
 			return await stripe.createPaymentMethod( {
 				card: elements?.getElement( elementToGet ),
-				type: 'card',
+				type: PAYMENT_METHOD_CARD,
 				billing_details: ownerInfo,
 			} );
 		};