Fix wrong price formatting in Apple/Google Pay (#4480)

* make 'three_decimal_currencies' method public

* use currency decimal supported in Stripe

* add changelog

* remove unnecessary else

* convert currency to lower case

* add test for test_get_stripe_currency_decimals

Author: Mayisha

changelog.txt

@@ -18,6 +18,7 @@
 * Fix - No such customer error when creating a payment method with a new Stripe account
 * Fix - Validate create customer payload against required billing fields before sending to Stripe
 * Update - Enhanced logging system with support for all log levels and improved context handling
+* Fix - Fixes wrong price formatting in express checkout
 * Fix - Require email address only for Stripe customer validation when request is from the Add Payment Method page
 * Fix - Set default values for custom field options
 * Fix - Enforce rate limiter for failed add payment method attempts

includes/class-wc-stripe-helper.php

@@ -306,7 +306,7 @@ public static function no_decimal_currencies() {
 	 *
 	 * @return array $currencies
 	 */
-	private static function three_decimal_currencies() {
+	public static function three_decimal_currencies() {
 		return [
 			'bhd', // Bahraini Dinar
 			'jod', // Jordanian Dinar

includes/payment-methods/class-wc-stripe-express-checkout-helper.php

@@ -314,6 +314,22 @@ public function get_allowed_shipping_countries() {
 		return array_keys( $allowed_shipping_countries );
 	}
 
+	/**
+	 * Get the number of decimals supported by Stripe for the currency.
+	 *
+	 * @return int
+	 */
+	public static function get_stripe_currency_decimals() {
+		$currency = strtolower( get_woocommerce_currency() );
+		if ( in_array( $currency, WC_Stripe_Helper::no_decimal_currencies(), true ) ) {
+			return 0;
+		} elseif ( in_array( $currency, WC_Stripe_Helper::three_decimal_currencies(), true ) ) {
+			return 3;
+		}
+
+		return 2;
+	}
+
 	/**
 	 * JS params data used by cart and checkout pages.
 	 *
@@ -323,7 +339,7 @@ public function get_checkout_data() {
 		$data = [
 			'url'                     => wc_get_checkout_url(),
 			'currency_code'           => strtolower( get_woocommerce_currency() ),
-			'currency_decimals'       => wc_get_price_decimals(),
+			'currency_decimals'       => $this->get_stripe_currency_decimals(),
 			'country_code'            => substr( get_option( 'woocommerce_default_country' ), 0, 2 ),
 			'needs_shipping'          => 'no',
 			'needs_payer_phone'       => 'required' === get_option( 'woocommerce_checkout_phone_field', 'required' ),

readme.txt

@@ -128,6 +128,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 * Fix - No such customer error when creating a payment method with a new Stripe account
 * Fix - Validate create customer payload against required billing fields before sending to Stripe
 * Update - Enhanced logging system with support for all log levels and improved context handling
+* Fix - Fixes wrong price formatting in express checkout
 * Fix - Require email address only for Stripe customer validation when request is from the Add Payment Method page
 * Fix - Set default values for custom field options
 * Fix - Enforce rate limiter for failed add payment method attempts

tests/phpunit/PaymentMethods/WC_Stripe_Express_Checkout_Helper_Test.php

@@ -637,4 +637,48 @@ public function provide_test_is_request_to_store_api() {
 			],
 		];
 	}
+
+	/**
+	 * Test for `get_stripe_currency_decimals`.
+	 *
+	 * @param string $currency Currency code.
+	 * @param int    $expected Expected number of decimals.
+	 *
+	 * @dataProvider provide_test_get_stripe_currency_decimals
+	 */
+	public function test_get_stripe_currency_decimals( $currency, $expected ) {
+		update_option( 'woocommerce_currency', $currency );
+
+		$actual = WC_Stripe_Express_Checkout_Helper::get_stripe_currency_decimals();
+		$this->assertEquals( $expected, $actual );
+	}
+
+	/**
+	 * Provider for `test_get_stripe_currency_decimals`.
+	 *
+	 * @return array
+	 */
+	public function provide_test_get_stripe_currency_decimals() {
+		return [
+			// No decimal currencies - should return 0
+			'Japanese Yen (no decimals)' => [
+				'currency' => 'JPY',
+				'expected' => 0,
+			],
+			// Three decimal currencies - should return 3
+			'Bahraini Dinar (three decimals)' => [
+				'currency' => 'BHD',
+				'expected' => 3,
+			],
+			// Default currencies - should return 2
+			'US Dollar (default)' => [
+				'currency' => 'USD',
+				'expected' => 2,
+			],
+			'Euro (default)' => [
+				'currency' => 'EUR',
+				'expected' => 2,
+			],
+		];
+	}
 }