Fix order received text filter when order object is invalid (#4074)

* Fix order received text filter when order object is invalid

* Adding unit tests

* Changelog and readme entries

Author: wjrosa

changelog.txt

@@ -4,6 +4,7 @@
 * Fix - Temporarily disables the subscriptions detached notice feature due to long loading times on stores with many subscriptions.
 * Fix - Update ACH capability check key
 * Fix - Update legacy checkout documentation links and deprecation notice display logic
+* Fix - Fixes an error with the `filter_thankyou_order_received_text` filter when it does not receive a valid WC_Order instance.
 
 = 9.3.0 - 2025-03-13 =
 * Dev - Adds a new README.md file to the plugin with specific development-focused instructions.

includes/payment-methods/class-wc-stripe-upe-payment-gateway.php

@@ -2956,11 +2956,11 @@ public function filter_my_account_my_orders_actions( $actions, $order ) {
 	 * Filter the order received text for Amazon Pay orders, including the delayed confirmation information.
 	 *
 	 * @param string $text Default text.
-	 * @param WC_Order $order Order data.
+	 * @param WC_Order|bool $order Order data.
 	 * @return string
 	 */
 	public function filter_thankyou_order_received_text( $text, $order ) {
-		if ( $order->get_payment_method_title() === 'Amazon Pay (Stripe)' && $order->has_status( 'pending' ) ) {
+		if ( is_a( $order, 'WC_Order' ) && $order->get_payment_method_title() === 'Amazon Pay (Stripe)' && $order->has_status( 'pending' ) ) {
 			$text .= '<p class="woocommerce-info">';
 			$text .= esc_html( 'The payment is being processed and it might take a few minutes before it\'s confirmed.' );
 			$text .= '</p>';

readme.txt

@@ -114,5 +114,6 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 * Fix - Temporarily disables the subscriptions detached notice feature due to long loading times on stores with many subscriptions.
 * Fix - Update ACH capability check key
 * Fix - Update legacy checkout documentation links and deprecation notice display logic
+* Fix - Fixes an error with the `filter_thankyou_order_received_text` filter when it does not receive a valid WC_Order instance.
 
 [See changelog for all versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).

tests/phpunit/payment-methods/test-class-wc-stripe-upe-payment-gateway.php

@@ -2834,15 +2834,22 @@ public function payment_method_titles_provider() {
 	 * @return void
 	 */
 	public function test_filter_thankyou_order_received_text() {
+		$default_text = 'Thank you. Your order has been received.';
+
+		// Order is invalid.
+		$actual   = $this->mock_gateway->filter_thankyou_order_received_text( $default_text, false );
+		$expected = $default_text;
+
+		$this->assertEquals( $expected, $actual );
+
+		// Order exists.
 		$order = WC_Helper_Order::create_order();
 		$order->set_status( 'pending' );
 		$order->set_payment_method_title( 'Amazon Pay (Stripe)' );
 
-		$default_text = 'Thank you. Your order has been received.';
-
-		$actual = $this->mock_gateway->filter_thankyou_order_received_text( $default_text, $order );
-
+		$actual   = $this->mock_gateway->filter_thankyou_order_received_text( $default_text, $order );
 		$expected = $default_text . '<p class="woocommerce-info">The payment is being processed and it might take a few minutes before it&#039;s confirmed.</p>';
+
 		$this->assertEquals( $expected, $actual );
 	}