Fix webhook order retrieval by intent charges (#3704)

* Fix webhook order retrieval by intent charges

* Changelog and readme entries

* Unit tests

Author: wjrosa

changelog.txt

@@ -1,6 +1,7 @@
 *** Changelog ***
 
 = 9.1.1 - xxxx-xx-xx =
+* Fix - Fixes the webhook order retrieval by intent charges. The processed event is an object, not an array.
 * Fix - Payment request button fails to display when the legacy checkout experience is enabled.
 * Fix - Resolves the payment element loading issue in the legacy checkout experience.
 

includes/class-wc-stripe-webhook-handler.php

@@ -1317,8 +1317,8 @@ private function get_order_from_intent( $intent ) {
 		// Try to retrieve from the charges array.
 		if ( ! empty( $intent->charges ) ) {
 			$charge   = $intent->charges[0] ?? [];
-			$order_id = $charge['metadata']['order_id'] ?? null;
-			return wc_get_order( $order_id );
+			$order_id = $charge->metadata->order_id ?? null;
+			return $order_id ? wc_get_order( $order_id ) : false;
 		}
 
 		// Fall back to finding the order via the intent ID.

readme.txt

@@ -111,6 +111,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 == Changelog ==
 
 = 9.1.1 - xxxx-xx-xx =
+* Fix - Fixes the webhook order retrieval by intent charges. The processed event is an object, not an array.
 * Fix - Payment request button fails to display when the legacy checkout experience is enabled.
 * Fix - Resolves the payment element loading issue in the legacy checkout experience.
 

tests/phpunit/test-wc-stripe-webhook-handler.php

@@ -433,21 +433,27 @@ public function test_process_payment_intent(
 		$order->save_meta_data();
 		$order->save();
 
-		$notification = (object) [
+		$notification = [
 			'type' => $event_type,
-			'data' => (object) [
-				'object' => (object) [
+			'data' => [
+				'object' => [
 					'id'                 => 'pi_mock',
-					'metadata'           => (object) [
-						'order_id' => $order->get_id(),
+					'charges'            => [
+						[
+							'metadata' => [
+								'order_id' => $order->get_id(),
+							],
+						],
 					],
-					'last_payment_error' => (object) [
+					'last_payment_error' => [
 						'message' => 'Your card was declined. You can call your bank for details.',
 					],
 				],
 			],
 		];
 
+		$notification = json_decode( wp_json_encode( $notification ) );
+
 		$this->mock_webhook_handler->process_payment_intent( $notification );
 
 		$final_order = wc_get_order( $order->get_id() );