Skip to content

Commit c3e261c

Browse files
authored
Use the correct property to check if product needs shipping (#3630)
1 parent c03c136 commit c3e261c

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* Fix - Resolve a fatal error by casting product price and subscription sign up fee to 'float' while adding them.
1313
* Fix - Return 'is_live' as true in account summary response when test mode is disabled in gateway settings and charge is enabled in Stripe account.
1414
* Fix - Prevents notices being displayed on WordPress 6.7 due to loading translations too early (only shown on stores with WP_DEBUG enabled).
15+
* Fix - Prevent showing the shipping options on express checkout modal for virtual product variations.
1516
* Tweak - Update links to plugin documentation and Stripe documentation.
1617

1718
= 8.9.0 - 2024-11-14 =

client/entrypoints/express-checkout/index.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,8 @@ jQuery( function ( $ ) {
513513
const needsShipping =
514514
! wcStripeECE.paymentAborted &&
515515
getExpressCheckoutData( 'product' )
516-
.needs_shipping === response.needs_shipping;
516+
.requestShipping ===
517+
response.requestShipping;
517518

518519
if ( ! isDeposits && needsShipping ) {
519520
elements.update( {
@@ -553,8 +554,8 @@ jQuery( function ( $ ) {
553554
if (
554555
! wcStripeECE.paymentAborted &&
555556
getExpressCheckoutData( 'product' )
556-
.needs_shipping ===
557-
response.needs_shipping
557+
.requestShipping ===
558+
response.requestShipping
558559
) {
559560
elements.update( {
560561
amount: response.total.amount,

readme.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
122122
* Fix - Resolve a fatal error by casting product price and subscription sign up fee to 'float' while adding them.
123123
* Fix - Return 'is_live' as true in account summary response when test mode is disabled in gateway settings and charge is enabled in Stripe account.
124124
* Fix - Prevents notices being displayed on WordPress 6.7 due to loading translations too early (only shown on stores with WP_DEBUG enabled).
125+
* Fix - Prevent showing the shipping options on express checkout modal for virtual product variations.
125126
* Tweak - Update links to plugin documentation and Stripe documentation.
126127

127128
[See changelog for all versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).

0 commit comments

Comments
 (0)