Fix division by zero fatal error (#4368)

* Fix division by zero fatal error

* Changelog and readme entries

* Logging when the division by zero is avoided

* Fix order param

* Replacing the default quantity behavior with a new exception

Author: wjrosa

changelog.txt

@@ -2,6 +2,7 @@
 
 = 9.5.3 - xxxx-xx-xx =
 * Fix - Reimplement mapping of Express Checkout state values to align with WooCommerce's expected state formats
+* Fix - Adds an exception to be thrown when the order item quantity is zero, during the retrieval of level 3 data from an order.
 * Tweak - Track charge completed via webhooks in order notes
 * Fix - Ensure that we migrate payment_request_button_size=medium on upgrade
 

includes/abstracts/abstract-wc-stripe-payment-gateway.php

@@ -1436,15 +1436,17 @@ public function generate_create_intent_request( $order, $prepared_source ) {
 	 *
 	 * @param WC_Order $order The order that is being paid for.
 	 * @return array          The level 3 data to send to Stripe.
+	 * @throws WC_Stripe_Exception If an order item has no quantity set.
 	 */
 	public function get_level3_data_from_order( $order ) {
 		// Get the order items. Don't need their keys, only their values.
 		// Order item IDs are used as keys in the original order items array.
 		$order_items = array_values( $order->get_items( [ 'line_item', 'fee' ] ) );
 		$currency    = $order->get_currency();
+		$order_id    = $order->get_id();
 
 		$stripe_line_items = array_map(
-			function ( $item ) use ( $currency ) {
+			function ( $item ) use ( $currency, $order_id ) {
 				if ( is_a( $item, 'WC_Order_Item_Product' ) ) {
 					$product_id = $item->get_variation_id()
 						? $item->get_variation_id()
@@ -1456,9 +1458,14 @@ function ( $item ) use ( $currency ) {
 				}
 				$product_description = substr( $item->get_name(), 0, 26 );
 				$quantity            = $item->get_quantity();
-				$unit_cost           = WC_Stripe_Helper::get_stripe_amount( ( $subtotal / $quantity ), $currency );
-				$tax_amount          = WC_Stripe_Helper::get_stripe_amount( $item->get_total_tax(), $currency );
-				$discount_amount     = WC_Stripe_Helper::get_stripe_amount( $subtotal - $item->get_total(), $currency );
+				if ( ! $quantity ) {
+					$error_msg = "Stripe Level 3 data: Order item with ID {$item->get_id()} from order ID {$order_id} has no quantity set.";
+					WC_Stripe_Logger::error( $error_msg );
+					throw new WC_Stripe_Exception( $error_msg );
+				}
+				$unit_cost       = WC_Stripe_Helper::get_stripe_amount( ( $subtotal / $quantity ), $currency );
+				$tax_amount      = WC_Stripe_Helper::get_stripe_amount( $item->get_total_tax(), $currency );
+				$discount_amount = WC_Stripe_Helper::get_stripe_amount( $subtotal - $item->get_total(), $currency );
 
 				return (object) [
 					'product_code'        => (string) $product_id, // Up to 12 characters that uniquely identify the product.

readme.txt

@@ -113,6 +113,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 = 9.5.3 - xxxx-xx-xx =
 
 * Fix - Reimplement mapping of Express Checkout state values to align with WooCommerce's expected state formats
+* Fix - Adds an exception to be thrown when the order item quantity is zero, during the retrieval of level 3 data from an order.
 * Tweak - Track charge completed via webhooks in order notes
 * Fix - Ensure that we migrate payment_request_button_size=medium on upgrade