Make ECE feature flag enabled by default for new accounts only (#3596)

* enable ece feature flag by default for new accounts only

* add changelog

* call the method

Author: Mayisha

changelog.txt

@@ -4,7 +4,7 @@
 * Fix - Hide express checkout when credit card payments are not enabled.
 * Fix - Fix issues when detaching payment methods on staging sites (with the new checkout experience enabled).
 * Fix - Display a notice if taxes vary by customer's billing address when checking out using the Stripe Express Checkout Element.
-* Tweak - Makes the new Stripe Express Checkout Element enabled by default.
+* Tweak - Makes the new Stripe Express Checkout Element enabled by default in new accounts.
 * Dev - Add multiple unit tests for the Stripe Express Checkout Element implementation (for both frontend and backend).
 * Fix - Check if taxes are enabled when applying ECE tax compatibility check.
 * Fix - Fix ECE error when initial address on load is not defined as a shipping zone.

includes/class-wc-stripe-feature-flags.php

@@ -14,7 +14,7 @@ class WC_Stripe_Feature_Flags {
 	 * @return bool
 	 */
 	public static function is_stripe_ece_enabled() {
-		return 'yes' === get_option( self::ECE_FEATURE_FLAG_NAME, 'yes' );
+		return 'yes' === get_option( self::ECE_FEATURE_FLAG_NAME, 'no' );
 	}
 
 	/**

includes/connect/class-wc-stripe-connect.php

@@ -173,6 +173,9 @@ private function save_stripe_keys( $result, $type = 'connect', $mode = 'live' )
 			unset( $options['account_id'] );
 			unset( $options['test_account_id'] );
 
+			// Enable ECE for new connections.
+			$this->enable_ece_in_new_accounts();
+
 			WC_Stripe_Helper::update_main_stripe_settings( $options );
 
 			// Similar to what we do for webhooks, we save some stats to help debug oauth problems.
@@ -213,6 +216,17 @@ private function get_upe_checkout_experience_enabled() {
 			return 'yes';
 		}
 
+		/**
+		 * Enable Stripe express checkout element for new connections.
+		 */
+		private function enable_ece_in_new_accounts() {
+			$existing_stripe_settings = WC_Stripe_Helper::get_stripe_settings();
+
+			if ( empty( $existing_stripe_settings ) ) {
+				update_option( WC_Stripe_Feature_Flags::ECE_FEATURE_FLAG_NAME, 'yes' );
+			}
+		}
+
 		/**
 		 * Gets default Stripe settings
 		 */

readme.txt

@@ -114,7 +114,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 * Fix - Hide express checkout when credit card payments are not enabled.
 * Fix - Fix issues when detaching payment methods on staging sites (with the new checkout experience enabled).
 * Fix - Display a notice if taxes vary by customer's billing address when checking out using the Stripe Express Checkout Element.
-* Tweak - Makes the new Stripe Express Checkout Element enabled by default.
+* Tweak - Makes the new Stripe Express Checkout Element enabled by default in new accounts.
 * Dev - Add multiple unit tests for the Stripe Express Checkout Element implementation (for both frontend and backend).
 * Fix - Check if taxes are enabled when applying ECE tax compatibility check.
 * Fix - Fix ECE error when initial address on load is not defined as a shipping zone.