Skip to content

Commit fd1ab0a

Browse files
authored
Fix ECE error on classic cart/checkout for non-English stores (#3685)
* Fix ECE error on classic cart/checkout for non-English stores * Add changelog and readme entries
1 parent 1caf146 commit fd1ab0a

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

changelog.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
*** Changelog ***
22

33
= 9.1.0 - xxxx-xx-xx =
4+
* Fix - Fix ECE crash in classic cart and checkout pages for non-English language sites.
45
* Fix - Correctly handles UK postcodes redacted by Apple Pay.
56
* Tweak - Avoid re-sending Processing Order customer email when merchant wins dispute.
67
* Fix - Allow the saving of iDEAL tokens when SEPA is disabled.
7-
* Fix - Fixes the incompatibility notice in editor due missing style property when instantiating Stripe payment methods.
8+
* Fix - Fixes the incompatibility notice in editor due missing style property when instantiating Stripe payment methods.
89
* Dev - Updates the GitHub caching action (`actions/cache`) to v4 due deprecation.
910
* Fix - Don't update canceled order status to on-hold when a dispute is opened.
1011
* Fix - Correctly sets the dispute opened note when a dispute does not require any further action.

client/entrypoints/express-checkout/index.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,9 @@ jQuery( function ( $ ) {
103103
}
104104

105105
return options.displayItems
106-
.filter(
107-
( i ) =>
108-
i.label ===
109-
__( 'Shipping', 'woocommerce-gateway-stripe' )
110-
)
106+
.filter( ( i ) => i.key && i.key === 'total_shipping' )
111107
.map( ( i ) => ( {
112-
id: `rate-${ i.label }`,
108+
id: `rate-shipping`,
113109
amount: i.amount,
114110
displayName: i.label,
115111
} ) );

readme.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,11 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
111111
== Changelog ==
112112

113113
= 9.1.0 - xxxx-xx-xx =
114+
* Fix - Fix ECE crash in classic cart and checkout pages for non-English language sites.
114115
* Fix - Correctly handles UK postcodes redacted by Apple Pay.
115116
* Tweak - Avoid re-sending Processing Order customer email when merchant wins dispute.
116117
* Fix - Allow the saving of iDEAL tokens when SEPA is disabled.
117-
* Fix - Fixes the incompatibility notice in editor due missing style property when instantiating Stripe payment methods.
118+
* Fix - Fixes the incompatibility notice in editor due missing style property when instantiating Stripe payment methods.
118119
* Dev - Updates the GitHub caching action (`actions/cache`) to v4 due deprecation.
119120
* Fix - Don't update canceled order status to on-hold when a dispute is opened.
120121
* Fix - Correctly sets the dispute opened note when a dispute does not require any further action.

0 commit comments

Comments
 (0)