Skip to content

Using the existing instantiation method for OC #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 22, 2025
Merged

Using the existing instantiation method for OC #4577

merged 6 commits into from
Aug 22, 2025

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Aug 12, 2025 •
edited
Loading

Changes proposed in this Pull Request:

This is a simple PR that just replaces some Optimized Checkout payment method instantiation duplicate code with the existing helper methods.

Testing instructions

Code review should be enough. Check if the tests are still passing.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Aug 13, 2025
@wjrosa wjrosa marked this pull request as ready for review August 20, 2025 08:30
@wjrosa wjrosa requested review from a team, diegocurbelo and annemirasol and removed request for a team August 20, 2025 08:31
diegocurbelo
diegocurbelo approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, $payment_method->get_id() returns the stripe_id, which is what get_payment_method_instance() uses as key for the UPE_AVAILABLE_METHODS array lookup.

@wjrosa wjrosa added this to the 9.9.0 milestone Aug 21, 2025
annemirasol
annemirasol approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjrosa wjrosa enabled auto-merge (squash) August 22, 2025 18:01
@wjrosa wjrosa merged commit 2f29de7 into develop Aug 22, 2025
40 checks passed
@wjrosa wjrosa deleted the dev/using-the-instantiation-method-for-oc branch August 22, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegocurbelo diegocurbelo diegocurbelo approved these changes

@annemirasol annemirasol annemirasol approved these changes

Assignees

@wjrosa wjrosa

Labels
None yet
Projects
None yet
Milestone
9.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wjrosa @diegocurbelo @annemirasol