[Beta fix] Hides GhostItemCardView rendering behind feature flag (#14373)

Author: iamgabrielma

Experiments/Experiments/DefaultFeatureFlagService.swift

@@ -90,6 +90,8 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .paymentsOnboardingInPointOfSale:
             return buildConfig == .localDeveloper
+        case .displayInfiniteScrollingUIDetailsInPointOfSale:
+            return buildConfig == .localDeveloper || buildConfig == .alpha
         default:
             return true
         }

Experiments/Experiments/FeatureFlag.swift

@@ -196,4 +196,8 @@ public enum FeatureFlag: Int {
     /// Supports Woo Payments onboarding in POS so that merchants who have not completed onboarding can access POS.
     ///
     case paymentsOnboardingInPointOfSale
+
+    /// Enables UI-related aspects of infinite scrolling in POS. It does not affect the actual infinite scrolling behaviour.
+    ///
+    case displayInfiniteScrollingUIDetailsInPointOfSale
 }

WooCommerce/Classes/POS/Presentation/ItemListView.swift

@@ -131,7 +131,7 @@ private extension ItemListView {
                     })
                 }
                 GhostItemCardView()
-                    .renderedIf(viewModel.state == .loading)
+                    .renderedIf(viewModel.shouldShowGhostableItemCard && viewModel.state == .loading)
             }
             .padding(.bottom, floatingControlAreaSize.height)
             .padding(.horizontal, Constants.itemListPadding)

WooCommerce/Classes/POS/Presentation/PointOfSaleEntryPointView.swift

@@ -26,7 +26,9 @@ struct PointOfSaleEntryPointView: View {
                                               currencyFormatter: currencyFormatter,
                                               paymentState: .acceptingCard)
         let cartViewModel = CartViewModel(analytics: analytics)
-        let itemListViewModel = ItemListViewModel(itemProvider: itemProvider)
+
+        let shouldShowGhostableItemCard = ServiceLocator.featureFlagService.isFeatureFlagEnabled(.displayInfiniteScrollingUIDetailsInPointOfSale)
+        let itemListViewModel = ItemListViewModel(itemProvider: itemProvider, shouldShowGhostableItemCard: shouldShowGhostableItemCard)
 
         self._viewModel = StateObject(wrappedValue: PointOfSaleDashboardViewModel(
             cardPresentPaymentService: cardPresentPaymentService,

WooCommerce/Classes/POS/ViewModels/ItemListViewModel.swift

@@ -12,6 +12,8 @@ final class ItemListViewModel: ItemListViewModelProtocol {
 
     @Published private var currentPage: Int = Constants.initialPage
 
+    private(set) var shouldShowGhostableItemCard: Bool = false
+
     var shouldShowHeaderBanner: Bool {
         // The banner it's shown as long as it hasn't already been dismissed once:
         if UserDefaults.standard.bool(forKey: BannerState.isSimpleProductsOnlyBannerDismissedKey) == true {
@@ -28,8 +30,9 @@ final class ItemListViewModel: ItemListViewModelProtocol {
     var itemsPublisher: Published<[POSItem]>.Publisher { $items }
     var statePublisher: Published<ItemListViewModel.ItemListState>.Publisher { $state }
 
-    init(itemProvider: POSItemProvider) {
+    init(itemProvider: POSItemProvider, shouldShowGhostableItemCard: Bool = false) {
         self.itemProvider = itemProvider
+        self.shouldShowGhostableItemCard = shouldShowGhostableItemCard
         selectedItemPublisher = selectedItemSubject.eraseToAnyPublisher()
     }