StoresManagerTests: Fixing Tests

Author: jleandroperez

WooCommerce/Classes/Yosemite/StoresManager.swift

@@ -49,6 +49,7 @@ class StoresManager {
 
     /// Switches the internal state to Authenticated.
     ///
+    @discardableResult
     func authenticate(credentials: Credentials) -> StoresManager {
         state = AuthenticatedState(credentials: credentials)
         sessionManager.defaultCredentials = credentials
@@ -58,15 +59,21 @@ class StoresManager {
 
     /// Synchronizes all of the Session's Entities.
     ///
-    func synchronizeEntities(onCompletion: ((Error?) -> Void)? = nil) {
+    @discardableResult
+    func synchronizeEntities(onCompletion: ((Error?) -> Void)? = nil) -> StoresManager {
         synchronizeAccount(onCompletion: onCompletion)
+
+        return self
     }
 
     /// Switches the state to a Deauthenticated one.
     ///
-    func deauthenticate() {
+    @discardableResult
+    func deauthenticate() -> StoresManager {
         state = DeauthenticatedState()
         sessionManager.reset()
+
+        return self
     }
 }
 

WooCommerce/WooCommerceTests/Yosemite/StoresManagerTests.swift

@@ -39,7 +39,7 @@ class StoresManagerTests: XCTestCase {
     ///
     func testAuthenticateEffectivelyTogglesStoreManagerToAuthenticatedState() {
         let manager = StoresManager.testingInstance
-        manager.authenticate(username: Settings.credentials.username, authToken: Settings.credentials.authToken, onCompletion: nil)
+        manager.authenticate(credentials: Settings.credentials)
 
         XCTAssertTrue(manager.isAuthenticated)
     }
@@ -49,7 +49,7 @@ class StoresManagerTests: XCTestCase {
     ///
     func testDeauthenticateEffectivelyTogglesStoreManagerToDeauthenticatedState() {
         let manager = StoresManager.testingInstance
-        manager.authenticate(username: Settings.credentials.username, authToken: Settings.credentials.authToken)
+        manager.authenticate(credentials: Settings.credentials)
         manager.deauthenticate()
 
         XCTAssertFalse(manager.isAuthenticated)
@@ -60,7 +60,7 @@ class StoresManagerTests: XCTestCase {
     ///
     func testAuthenticatePersistsDefaultCredentialsInKeychain() {
         let manager = StoresManager.testingInstance
-        manager.authenticate(username: Settings.credentials.username, authToken: Settings.credentials.authToken)
+        manager.authenticate(credentials: Settings.credentials)
 
         let session = SessionManager.testingInstance
         XCTAssertEqual(session.defaultCredentials, Settings.credentials)