Better named variables

Author: mindgraffiti

WooCommerce/Classes/Analytics/AnalyticsProvider.swift

@@ -22,11 +22,11 @@ public protocol AnalyticsProvider {
     ///
     func track(_ eventName: String, withProperties properties: [AnyHashable: Any]?)
 
-    /// Clear queued track events
+    /// Clear queued events
     ///
-    func clearTracksEvents()
+    func clearEvents()
 
     /// Switch between an authed user and anon user
     ///
-    func clearTracksUsers()
+    func clearUsers()
 }

WooCommerce/Classes/Analytics/TracksProvider.swift

@@ -42,13 +42,13 @@ public extension TracksProvider {
         }
     }
 
-    func clearTracksEvents() {
+    func clearEvents() {
         tracksService.clearQueuedEvents()
     }
 
     /// When a user opts-out, wipe data
     ///
-    func clearTracksUsers() {
+    func clearUsers() {
         guard WooAnalytics.shared.userHasOptedIn else {
             // To be safe, nil out the anonymousUserID guid so a fresh one is regenerated
             UserDefaults.standard[.defaultAnonymousID] = nil

WooCommerce/Classes/Analytics/WooAnalytics.swift

@@ -131,8 +131,8 @@ extension WooAnalytics {
             DDLogInfo("🔵 Tracking started.")
         } else {
             stopObservingNotifications()
-            analyticsProvider.clearTracksEvents()
-            analyticsProvider.clearTracksUsers()
+            analyticsProvider.clearEvents()
+            analyticsProvider.clearUsers()
             DDLogInfo("🔴 Tracking opt-out complete.")
         }
     }

WooCommerce/WooCommerceTests/Mockups/MockupAnalyticsProvider.swift

@@ -29,11 +29,11 @@ public extension MockupAnalyticsProvider {
         }
     }
 
-    func clearTracksEvents() {
+    func clearEvents() {
         receivedEvents.removeAll()
     }
 
-    func clearTracksUsers() {
+    func clearUsers() {
         userOptedIn = false
         userID = nil
     }

WooCommerce/WooCommerceTests/System/WooAnalyticsTests.swift

@@ -93,15 +93,15 @@ class WooAnalyticsTests: XCTestCase {
     /// Test user opted out
     ///
     func testUserOptedOut() {
-        testingProvider?.clearTracksUsers()
+        testingProvider?.clearUsers()
         XCTAssertTrue(testingProvider?.userID == nil)
         XCTAssertTrue(testingProvider?.userOptedIn == false)
     }
 
     /// Test clear all events
     ///
     func testClearAllEvents() {
-        testingProvider?.clearTracksEvents()
+        testingProvider?.clearEvents()
         XCTAssertEqual(testingProvider?.receivedEvents.count, 0)
     }
 }