Skip to content

Commit 115f43a

Browse files
committed
Minor improvements before making a PR.
1 parent 80f99cd commit 115f43a

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

Networking/Networking/Model/Media/WordPressMedia.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import Codegen
2-
31
/// Media from WordPress Site API
42
public struct WordPressMedia: Equatable {
53
public let mediaID: Int64

Networking/Networking/Remote/MediaRemote.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,11 @@ public class MediaRemote: Remote {
4646
public func loadMediaLibraryFromWordPressSite(siteID: Int64,
4747
pageNumber: Int = Default.pageNumber,
4848
pageSize: Int = 25,
49-
context: String = Default.context,
5049
completion: @escaping (Result<[WordPressMedia], Error>) -> Void) {
5150
let parameters: [String: Any] = [
5251
ParameterKey.pageSize: pageSize,
5352
ParameterKey.pageNumber: pageNumber,
54-
ParameterKey.fieldsWordPressSite: Default.wordPressMediaFields,
53+
ParameterKey.fieldsWordPressSite: ParameterValue.wordPressMediaFields,
5554
ParameterKey.mimeType: "image"
5655
]
5756

@@ -123,8 +122,8 @@ public class MediaRemote: Remote {
123122
mediaItems: [UploadableMedia],
124123
completion: @escaping (Result<WordPressMedia, Error>) -> Void) {
125124
let formParameters: [String: String] = [
126-
"post": "\(productID)",
127-
ParameterKey.fieldsWordPressSite: Default.wordPressMediaFields,
125+
ParameterKey.wordPressMediaPostID: "\(productID)",
126+
ParameterKey.fieldsWordPressSite: ParameterValue.wordPressMediaFields,
128127
]
129128
let path = "sites/\(siteID)/media"
130129
let request = DotcomRequest(wordpressApiVersion: .wpMark2, method: .post, path: path, parameters: nil)
@@ -152,12 +151,12 @@ public extension MediaRemote {
152151
enum Default {
153152
public static let context: String = "display"
154153
public static let pageNumber = 1
155-
fileprivate static let wordPressMediaFields = "id,date_gmt,slug,mime_type,source_url,alt_text,media_details,title"
156154
}
157155

158156
private enum ParameterKey {
159157
static let pageNumber: String = "page"
160158
static let pageSize: String = "number"
159+
static let wordPressMediaPostID: String = "post"
161160
static let fields: String = "fields"
162161
static let fieldsWordPressSite: String = "_fields"
163162
static let mimeType: String = "mime_type"
@@ -166,5 +165,6 @@ public extension MediaRemote {
166165

167166
private enum ParameterValue {
168167
static let mediaUploadName: String = "file"
168+
static let wordPressMediaFields = "id,date_gmt,slug,mime_type,source_url,alt_text,media_details,title"
169169
}
170170
}

0 commit comments

Comments
 (0)