Renamed IntegerInputFormatter to PositiveIntegerInputFormatter since it accept only positive integers

pmusolino · pmusolino · commit 131172162532 · 2020-04-24T13:36:46.000+02:00
diff --git a/WooCommerce/Classes/Tools/UnitInputFormatter/PositiveIntegerInputFormatter.swift b/WooCommerce/Classes/Tools/UnitInputFormatter/PositiveIntegerInputFormatter.swift
@@ -1,8 +1,8 @@
 import Foundation
 
-/// `UnitInputFormatter` implementation for integer number input.
+/// `UnitInputFormatter` implementation for positive integer number input.
 ///
-struct IntegerInputFormatter: UnitInputFormatter {
+struct PositiveIntegerInputFormatter: UnitInputFormatter {
     func isValid(input: String) -> Bool {
         guard input.isEmpty == false else {
             // Allows empty input to be replaced by 0.
diff --git a/WooCommerce/Classes/ViewRelated/Products/Edit Product/Inventory Settings/Product+InventorySettingsViewModels.swift b/WooCommerce/Classes/ViewRelated/Products/Edit Product/Inventory Settings/Product+InventorySettingsViewModels.swift
@@ -21,7 +21,7 @@ extension Product {
                                   placeholder: "0",
                                   unitPosition: .none,
                                   keyboardType: .numberPad,
-                                  inputFormatter: IntegerInputFormatter(),
+                                  inputFormatter: PositiveIntegerInputFormatter(),
                                   onInputChange: onInputChange)
     }
 }
diff --git a/WooCommerce/Classes/ViewRelated/Products/Edit Product/Product Settings/Menu Order/ProductMenuOrderViewController.swift b/WooCommerce/Classes/ViewRelated/Products/Edit Product/Product Settings/Menu Order/ProductMenuOrderViewController.swift
@@ -139,7 +139,7 @@ private extension ProductMenuOrderViewController {
             }
             }, onTextDidBeginEditing: {
                 //TODO: Add analytics track
-        }, inputFormatter: IntegerInputFormatter())
+        }, inputFormatter: PositiveIntegerInputFormatter())
         cell.configure(viewModel: viewModel)
         cell.textField.applyBodyStyle()
         cell.textField.keyboardType = .decimalPad
diff --git a/WooCommerce/WooCommerce.xcodeproj/project.pbxproj b/WooCommerce/WooCommerce.xcodeproj/project.pbxproj
@@ -25,8 +25,8 @@
 		0202B6922387AB0C00F3EBE0 /* WooTab+Tag.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0202B6912387AB0C00F3EBE0 /* WooTab+Tag.swift */; };
 		0202B6952387AD1B00F3EBE0 /* UITabBar+Order.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0202B6942387AD1B00F3EBE0 /* UITabBar+Order.swift */; };
 		0206483A23FA4160008441BB /* OrdersRootViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0206483923FA4160008441BB /* OrdersRootViewController.swift */; };
-		020B2F8F23BD9F1F00BD79AD /* IntegerInputFormatter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020B2F8E23BD9F1F00BD79AD /* IntegerInputFormatter.swift */; };
-		020B2F9123BDD71500BD79AD /* IntegerInputFormatterTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020B2F9023BDD71500BD79AD /* IntegerInputFormatterTests.swift */; };
+		020B2F8F23BD9F1F00BD79AD /* PositiveIntegerInputFormatter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020B2F8E23BD9F1F00BD79AD /* PositiveIntegerInputFormatter.swift */; };
+		020B2F9123BDD71500BD79AD /* PositiveIntegerInputFormatterTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020B2F9023BDD71500BD79AD /* PositiveIntegerInputFormatterTests.swift */; };
 		020B2F9423BDDBDC00BD79AD /* ProductUpdateError+UI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020B2F9323BDDBDC00BD79AD /* ProductUpdateError+UI.swift */; };
 		020B2F9923BDF2E000BD79AD /* DefaultProductFormTableViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020B2F9823BDF2E000BD79AD /* DefaultProductFormTableViewModelTests.swift */; };
 		020BE74823B05CF2007FE54C /* ProductInventoryEditableData.swift in Sources */ = {isa = PBXBuildFile; fileRef = 020BE74723B05CF2007FE54C /* ProductInventoryEditableData.swift */; };
@@ -840,8 +840,8 @@
 		0202B6912387AB0C00F3EBE0 /* WooTab+Tag.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "WooTab+Tag.swift"; sourceTree = "<group>"; };
 		0202B6942387AD1B00F3EBE0 /* UITabBar+Order.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UITabBar+Order.swift"; sourceTree = "<group>"; };
 		0206483923FA4160008441BB /* OrdersRootViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OrdersRootViewController.swift; sourceTree = "<group>"; };
-		020B2F8E23BD9F1F00BD79AD /* IntegerInputFormatter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = IntegerInputFormatter.swift; sourceTree = "<group>"; };
-		020B2F9023BDD71500BD79AD /* IntegerInputFormatterTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = IntegerInputFormatterTests.swift; sourceTree = "<group>"; };
+		020B2F8E23BD9F1F00BD79AD /* PositiveIntegerInputFormatter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PositiveIntegerInputFormatter.swift; sourceTree = "<group>"; };
+		020B2F9023BDD71500BD79AD /* PositiveIntegerInputFormatterTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PositiveIntegerInputFormatterTests.swift; sourceTree = "<group>"; };
 		020B2F9323BDDBDC00BD79AD /* ProductUpdateError+UI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "ProductUpdateError+UI.swift"; sourceTree = "<group>"; };
 		020B2F9823BDF2E000BD79AD /* DefaultProductFormTableViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DefaultProductFormTableViewModelTests.swift; sourceTree = "<group>"; };
 		020BE74723B05CF2007FE54C /* ProductInventoryEditableData.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProductInventoryEditableData.swift; sourceTree = "<group>"; };
@@ -2056,7 +2056,7 @@
 				02913E9623A774E600707A0C /* DecimalInputFormatter.swift */,
 				45B9C64223A91CB6007FC4C5 /* PriceInputFormatter.swift */,
 				021E2A1D23AA24C600B1DE07 /* StringInputFormatter.swift */,
-				020B2F8E23BD9F1F00BD79AD /* IntegerInputFormatter.swift */,
+				020B2F8E23BD9F1F00BD79AD /* PositiveIntegerInputFormatter.swift */,
 				45F5A3C023DF206B007D40E5 /* ShippingInputFormatter.swift */,
 			);
 			path = UnitInputFormatter;
@@ -2533,7 +2533,7 @@
 				D83F5936225B402E00626E75 /* EditableValueOneTableViewCellTests.swift */,
 				D82DFB4B225F303200EFE2CB /* EmptyListMessageWithActionTests.swift */,
 				D8F82AC422AF903700B67E4B /* IconsTests.swift */,
-				020B2F9023BDD71500BD79AD /* IntegerInputFormatterTests.swift */,
+				020B2F9023BDD71500BD79AD /* PositiveIntegerInputFormatterTests.swift */,
 				D8C11A6122E24C4A00D4A88D /* LedgerTableViewCellTests.swift */,
 				D83F593C225B4B5000626E75 /* ManualTrackingViewControllerTests.swift */,
 				D8AB131D225DC25F002BB5D1 /* MockOrders.swift */,
@@ -4520,7 +4520,7 @@
 				B57C5C9421B80E4700FF82B2 /* Data+Woo.swift in Sources */,
 				CE22E3FB21714776005A6BEF /* TopLeftImageTableViewCell.swift in Sources */,
 				B554E17B2152F27200F31188 /* UILabel+Appearance.swift in Sources */,
-				020B2F8F23BD9F1F00BD79AD /* IntegerInputFormatter.swift in Sources */,
+				020B2F8F23BD9F1F00BD79AD /* PositiveIntegerInputFormatter.swift in Sources */,
 				7441EBC9226A71AA008BF83D /* TitleBodyTableViewCell.swift in Sources */,
 				B541B21C2189F3D8008FE7C1 /* StringStyles.swift in Sources */,
 				B58B4AB82108F14700076FDD /* NoticeNotificationInfo.swift in Sources */,
@@ -4840,7 +4840,7 @@
 				022A45EE237BADA6001417F0 /* Product+ProductFormTests.swift in Sources */,
 				B57C5C9921B80E7100FF82B2 /* DictionaryWooTests.swift in Sources */,
 				0290E27E238E5B5C00B5C466 /* ProductStockStatusListSelectorDataSourceTests.swift in Sources */,
-				020B2F9123BDD71500BD79AD /* IntegerInputFormatterTests.swift in Sources */,
+				020B2F9123BDD71500BD79AD /* PositiveIntegerInputFormatterTests.swift in Sources */,
 				D816DDBC22265DA300903E59 /* OrderTrackingTableViewCellTests.swift in Sources */,
 				D85136DD231E613900DD0539 /* ReviewsViewModelTests.swift in Sources */,
 				D85B833D2230DC9D002168F3 /* StringWooTests.swift in Sources */,
diff --git a/WooCommerce/WooCommerceTests/Tools/PositiveIntegerInputFormatterTests.swift b/WooCommerce/WooCommerceTests/Tools/PositiveIntegerInputFormatterTests.swift
@@ -2,8 +2,8 @@ import XCTest
 
 @testable import WooCommerce
 
-final class IntegerInputFormatterTests: XCTestCase {
-    private let formatter = IntegerInputFormatter()
+final class PositiveIntegerInputFormatterTests: XCTestCase {
+    private let formatter = PositiveIntegerInputFormatter()
 
     // MARK: test cases for `isValid(input:)`
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ extension Product {`
`21`	`21`	`placeholder: "0",`
`22`	`22`	`unitPosition: .none,`
`23`	`23`	`keyboardType: .numberPad,`
`24`		`- inputFormatter: IntegerInputFormatter(),`
	`24`	`+ inputFormatter: PositiveIntegerInputFormatter(),`
`25`	`25`	`onInputChange: onInputChange)`
`26`	`26`	`}`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ private extension ProductMenuOrderViewController {`
`139`	`139`	`}`
`140`	`140`	`}, onTextDidBeginEditing: {`
`141`	`141`	`//TODO: Add analytics track`
`142`		`- }, inputFormatter: IntegerInputFormatter())`
	`142`	`+ }, inputFormatter: PositiveIntegerInputFormatter())`
`143`	`143`	`cell.configure(viewModel: viewModel)`
`144`	`144`	`cell.textField.applyBodyStyle()`
`145`	`145`	`cell.textField.keyboardType = .decimalPad`