Cancel payment task when disconnecting reader

staskus · staskus · commit 141dc69f2a5f · 2025-02-03T16:45:05.000+02:00
If reader is disconnected while the payment is already being collected, then task never finishes. It could cause memory leaks due to stalled Tasks
diff --git a/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentService.swift b/WooCommerce/Classes/POS/Card Present Payments/CardPresentPaymentService.swift
@@ -108,6 +108,7 @@ final class CardPresentPaymentService: CardPresentPaymentFacade {
             DDLogError("Attempting to cancel the payment has failed \(error)")
         }
 
+        paymentTask?.cancel()
         connectionControllerManager.knownReaderProvider.forgetCardReader()
 
         return await withCheckedContinuation { continuation in

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ final class CardPresentPaymentService: CardPresentPaymentFacade {`
`108`	`108`	`DDLogError("Attempting to cancel the payment has failed \(error)")`
`109`	`109`	`}`
`110`	`110`
	`111`	`+ paymentTask?.cancel()`
`111`	`112`	`connectionControllerManager.knownReaderProvider.forgetCardReader()`
`112`	`113`
`113`	`114`	`return await withCheckedContinuation { continuation in`