Do not trigger API request for empty array of missing items

ealeksandrov · ealeksandrov · commit 1440ac75fe61 · 2022-06-23T20:58:27.000+03:00
diff --git a/Yosemite/Yosemite/Stores/ProductStore.swift b/Yosemite/Yosemite/Stores/ProductStore.swift
@@ -211,6 +211,12 @@ private extension ProductStore {
             }
         }
 
+        // Do not trigger API request for empty array of items
+        guard !missingIDs.isEmpty else {
+            onCompletion(nil)
+            return
+        }
+
         remote.loadProducts(for: order.siteID, by: missingIDs) { [weak self] result in
             switch result {
             case .success(let products):

Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,12 @@ private extension ProductStore {`
`211`	`211`	`}`
`212`	`212`	`}`
`213`	`213`
	`214`	`+ // Do not trigger API request for empty array of items`
	`215`	`+ guard !missingIDs.isEmpty else {`
	`216`	`+ onCompletion(nil)`
	`217`	`+ return`
	`218`	`+ }`
	`219`	`+`
`214`	`220`	`remote.loadProducts(for: order.siteID, by: missingIDs) { [weak self] result in`
`215`	`221`	`switch result {`
`216`	`222`	`case .success(let products):`