feat: migrated syncing first page in Inbox from List to LazyVStack

pmusolino · pmusolino · commit 16f4ed55408b · 2022-02-15T15:39:58.000+01:00
diff --git a/WooCommerce/Classes/ViewRelated/Inbox/Inbox.swift b/WooCommerce/Classes/ViewRelated/Inbox/Inbox.swift
@@ -29,14 +29,16 @@ struct Inbox: View {
                            image: .emptyProductsTabImage)
                     .frame(maxHeight: .infinity)
             case .syncingFirstPage:
-                List {
-                    ForEach(viewModel.placeholderRowViewModels) { rowViewModel in
-                        InboxNoteRow(viewModel: rowViewModel)
-                            .redacted(reason: .placeholder)
-                            .shimmering()
+                ScrollView {
+                    LazyVStack(spacing: 0) {
+                        ForEach(viewModel.placeholderRowViewModels) { rowViewModel in
+                            InboxNoteRow(viewModel: rowViewModel)
+                                .redacted(reason: .placeholder)
+                                .shimmering()
+                        }
+                        .background(Color(.listForeground))
                     }
                 }
-                .listStyle(PlainListStyle())
             }
         }
         .background(Color(.listBackground).ignoresSafeArea())

Original file line number	Diff line number	Diff line change
`@@ -29,14 +29,16 @@ struct Inbox: View {`
`29`	`29`	`image: .emptyProductsTabImage)`
`30`	`30`	`.frame(maxHeight: .infinity)`
`31`	`31`	`case .syncingFirstPage:`
`32`		`- List {`
`33`		`- ForEach(viewModel.placeholderRowViewModels) { rowViewModel in`
`34`		`- InboxNoteRow(viewModel: rowViewModel)`
`35`		`- .redacted(reason: .placeholder)`
`36`		`- .shimmering()`
	`32`	`+ ScrollView {`
	`33`	`+ LazyVStack(spacing: 0) {`
	`34`	`+ ForEach(viewModel.placeholderRowViewModels) { rowViewModel in`
	`35`	`+ InboxNoteRow(viewModel: rowViewModel)`
	`36`	`+ .redacted(reason: .placeholder)`
	`37`	`+ .shimmering()`
	`38`	`+ }`
	`39`	`+ .background(Color(.listForeground))`
`37`	`40`	`}`
`38`	`41`	`}`
`39`		`- .listStyle(PlainListStyle())`
`40`	`42`	`}`
`41`	`43`	`}`
`42`	`44`	`.background(Color(.listBackground).ignoresSafeArea())`