Attempt fixing reuse issue for the overlays on the product tab table cells

itsmeichigo · itsmeichigo · commit 1bdbcb35ece3 · 2025-02-11T18:23:35.000+07:00
diff --git a/WooCommerce/Classes/ViewRelated/Products/Cells/ProductsTabProductTableViewCell.swift b/WooCommerce/Classes/ViewRelated/Products/Cells/ProductsTabProductTableViewCell.swift
@@ -58,6 +58,14 @@ final class ProductsTabProductTableViewCell: UITableViewCell {
         super.updateConfiguration(using: state)
         updateDefaultBackgroundConfiguration(using: state)
     }
+
+    override func prepareForReuse() {
+        super.prepareForReuse()
+        syncingOverlayView?.removeFromSuperview()
+        selectedProductImageOverlayView?.removeFromSuperview()
+        syncingOverlayView = nil
+        selectedProductImageOverlayView = nil
+    }
 }
 
 extension ProductsTabProductTableViewCell: SearchResultCell {

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,14 @@ final class ProductsTabProductTableViewCell: UITableViewCell {`
`58`	`58`	`super.updateConfiguration(using: state)`
`59`	`59`	`updateDefaultBackgroundConfiguration(using: state)`
`60`	`60`	`}`
	`61`	`+`
	`62`	`+ override func prepareForReuse() {`
	`63`	`+ super.prepareForReuse()`
	`64`	`+ syncingOverlayView?.removeFromSuperview()`
	`65`	`+ selectedProductImageOverlayView?.removeFromSuperview()`
	`66`	`+ syncingOverlayView = nil`
	`67`	`+ selectedProductImageOverlayView = nil`
	`68`	`+ }`
`61`	`69`	`}`
`62`	`70`
`63`	`71`	`extension ProductsTabProductTableViewCell: SearchResultCell {`