Merge pull request #7459 from woocommerce/issue/adjust-orders-report-request-frequency

Adjust orders report request frequency

Author: ThomazFB

WooCommerce/Classes/Authentication/Epilogue/SwitchStoreUseCase.swift

@@ -43,8 +43,6 @@ final class SwitchStoreUseCase: SwitchStoreUseCaseProtocol {
         logOutOfCurrentStore {
             self.finalizeStoreSelection(storeID)
 
-            // Reload orders badge
-            NotificationCenter.default.post(name: .ordersBadgeReloadRequired, object: nil)
             onCompletion(true)
         }
     }

WooCommerce/Classes/ViewModels/MainTabViewModel.swift

@@ -83,7 +83,6 @@ final class MainTabViewModel {
     func startObservingOrdersCount() {
         observeBadgeRefreshNotifications()
         updateBadgeFromCache()
-        requestBadgeCount()
     }
 
     /// Loads the the hub Menu tab badge and listens to any change to update it

WooCommerce/Classes/ViewRelated/Orders/OrderListViewController.swift

@@ -161,8 +161,6 @@ final class OrderListViewController: UIViewController, GhostableViewController {
     override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
 
-        viewModel.syncOrderStatuses()
-
         syncingCoordinator.resynchronize(reason: SyncReason.viewWillAppear.rawValue)
 
         // Fix any incomplete animation of the refresh control
@@ -304,7 +302,7 @@ extension OrderListViewController {
     @objc func pullToRefresh(sender: UIRefreshControl) {
         ServiceLocator.analytics.track(.ordersListPulledToRefresh)
         delegate?.orderListViewControllerWillSynchronizeOrders(self)
-        viewModel.syncOrderStatuses()
+        NotificationCenter.default.post(name: .ordersBadgeReloadRequired, object: nil)
         syncingCoordinator.resynchronize(reason: SyncReason.pullToRefresh.rawValue) {
             sender.endRefreshing()
         }

WooCommerce/Classes/ViewRelated/Orders/OrderListViewModel.swift

@@ -240,18 +240,6 @@ final class OrderListViewModel {
         )
     }
 
-    /// Fetch all `OrderStatus` from the API
-    ///
-    func syncOrderStatuses() {
-        let action = OrderStatusAction.retrieveOrderStatuses(siteID: siteID) { result in
-            if case let .failure(error) = result {
-                DDLogError("⛔️ Order List — Error synchronizing order statuses: \(error)")
-            }
-        }
-
-        stores.dispatch(action)
-    }
-
     func updateFilters(filters: FilterOrderListViewModel.Filters?) {
         self.filters = filters
     }

WooCommerce/Classes/ViewRelated/Orders/OrdersRootViewController.swift

@@ -102,12 +102,6 @@ final class OrdersRootViewController: UIViewController {
         }
     }
 
-    override func viewWillAppear(_ animated: Bool) {
-        super.viewWillAppear(animated)
-
-        ServiceLocator.pushNotesManager.resetBadgeCount(type: .storeOrder)
-    }
-
     override var shouldShowOfflineBanner: Bool {
         if featureFlagService.isFeatureFlagEnabled(.splitViewInOrdersTab) {
             return false