Sync plugins when settings is opened

This ensures that we have the latest plugin data to show whether the WooCommerce plugin has available updates. If we don’t sync it when settings is opened, we may be relying on very old stored data, depending on the user’s usage pattern for the app.

Previously, the plugins were only synced on login/fresh launch, or for a few IPP-related actions.

Author: joshheald

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Settings/SettingsViewModel.swift

@@ -134,6 +134,13 @@ final class SettingsViewModel: SettingsViewModelOutput, SettingsViewModelActions
         } else {
             paymentGatewayAccountsResultsController = nil
         }
+
+        /// Synchronize system plugins for the WooCommerce plugin version row
+        ///
+        if let siteID = stores.sessionManager.defaultSite?.siteID {
+            let action = SystemStatusAction.synchronizeSystemPlugins(siteID: siteID, onCompletion: { _ in })
+            stores.dispatch(action)
+        }
     }
 
     /// Sets up the view model and loads the settings.