Update tests from products_m5 to products_variations feedback type

Author: ealeksandrov

WooCommerce/WooCommerceTests/ViewRelated/Products/ProductsTopBannerFactoryTests.swift

@@ -28,7 +28,7 @@ final class ProductsTopBannerFactoryTests: XCTestCase {
 
     func test_it_tracks_featureFeedbackBanner_gaveFeedback_event_when_giveFeedback_button_is_pressed() throws {
         // Given
-        let bannerMirror = try makeBannerViewMirror(for: .productsM4)
+        let bannerMirror = try makeBannerViewMirror(for: .variations)
         let giveFeedbackButton = try XCTUnwrap(bannerMirror.actionButtons.first)
 
         assertEmpty(analyticsProvider.receivedEvents)
@@ -41,7 +41,7 @@ final class ProductsTopBannerFactoryTests: XCTestCase {
         XCTAssertEqual(analyticsProvider.receivedEvents.first, "feature_feedback_banner")
 
         let properties = try XCTUnwrap(analyticsProvider.receivedProperties.first)
-        XCTAssertEqual(properties["context"] as? String, "products_m4")
+        XCTAssertEqual(properties["context"] as? String, "products_variations")
         XCTAssertEqual(properties["action"] as? String, "gave_feedback")
     }
 

WooCommerce/WooCommerceTests/ViewRelated/Survey/SurveyViewControllerTests.swift

@@ -24,17 +24,16 @@ final class SurveyViewControllerTests: XCTestCase {
 
     func test_it_loads_the_correct_product_feedback_survey() throws {
         // Given
-        let viewController = SurveyViewController(survey: .productsM5Feedback, onCompletion: {})
+        let viewController = SurveyViewController(survey: .productsVariationsFeedback, onCompletion: {})
 
         // When
         _ = try XCTUnwrap(viewController.view)
         let mirror = try self.mirror(of: viewController)
 
         // Then
         XCTAssertTrue(mirror.webView.isLoading)
-        XCTAssertEqual(mirror.webView.url, WooConstants.URLs.productsM4Feedback
+        XCTAssertEqual(mirror.webView.url, WooConstants.URLs.productsFeedback
                         .asURL().tagPlatform("ios")
-                        .tagProductMilestone("5")
                         .tagAppVersion(Bundle.main.bundleVersion()))
     }
 

Yosemite/YosemiteTests/Stores/AppSettings/InAppFeedbackCardVisibilityUseCaseTests.swift

@@ -158,7 +158,7 @@ final class InAppFeedbackCardVisibilityUseCaseTests: XCTestCase {
     func test_shouldBeVisible_for_productM5_is_true_if_no_settings_are_found() throws {
         // Given
         let settings = GeneralAppSettings(installationDate: nil, feedbacks: [:])
-        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsM5)
+        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsVariations)
 
         // When
         let shouldBeVisible = try useCase.shouldBeVisible()
@@ -169,8 +169,8 @@ final class InAppFeedbackCardVisibilityUseCaseTests: XCTestCase {
 
     func test_shouldBeVisible_for_productM5_is_true_if_feedback_has_pending_status() throws {
         // Given
-        let settings = createAppSetting(instalationDate: nil, feedbackType: .productsM5, feedbackSatus: .pending)
-        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsM5)
+        let settings = createAppSetting(instalationDate: nil, feedbackType: .productsVariations, feedbackSatus: .pending)
+        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsVariations)
 
         // When
         let shouldBeVisible = try useCase.shouldBeVisible()
@@ -181,8 +181,8 @@ final class InAppFeedbackCardVisibilityUseCaseTests: XCTestCase {
 
     func test_shouldBeVisible_for_productM5_is_false_if_feedback_has_dismissed_status() throws {
         // Given
-        let settings = createAppSetting(instalationDate: nil, feedbackType: .productsM5, feedbackSatus: .dismissed)
-        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsM5)
+        let settings = createAppSetting(instalationDate: nil, feedbackType: .productsVariations, feedbackSatus: .dismissed)
+        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsVariations)
 
         // When
         let shouldBeVisible = try useCase.shouldBeVisible()
@@ -193,8 +193,8 @@ final class InAppFeedbackCardVisibilityUseCaseTests: XCTestCase {
 
     func test_shouldBeVisible_for_productM5_is_false_if_feedback_has_given_status() throws {
         // Given
-        let settings = createAppSetting(instalationDate: nil, feedbackType: .productsM5, feedbackSatus: .given(Date()))
-        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsM5)
+        let settings = createAppSetting(instalationDate: nil, feedbackType: .productsVariations, feedbackSatus: .given(Date()))
+        let useCase = InAppFeedbackCardVisibilityUseCase(settings: settings, feedbackType: .productsVariations)
 
         // When
         let shouldBeVisible = try useCase.shouldBeVisible()

Yosemite/YosemiteTests/Stores/AppSettingsStoreTests.swift

@@ -355,12 +355,12 @@ final class AppSettingsStoreTests: XCTestCase {
     func test_loadFeedbackVisibility_for_productsM5_returns_true_after_marking_it_as_pending() throws {
         // Given
         try fileStorage?.deleteFile(at: expectedGeneralAppSettingsFileURL)
-        let updateAction = AppSettingsAction.updateFeedbackStatus(type: .productsM5, status: .pending) { _ in }
+        let updateAction = AppSettingsAction.updateFeedbackStatus(type: .productsVariations, status: .pending) { _ in }
         subject?.onAction(updateAction)
 
         // When
         var visibilityResult: Result<Bool, Error>?
-        let queryAction = AppSettingsAction.loadFeedbackVisibility(type: .productsM5) { result in
+        let queryAction = AppSettingsAction.loadFeedbackVisibility(type: .productsVariations) { result in
             visibilityResult = result
         }
         subject?.onAction(queryAction)
@@ -375,12 +375,12 @@ final class AppSettingsStoreTests: XCTestCase {
     func test_loadFeedbackVisibility_for_productsM5_returns_false_after_marking_it_as_dismissed() throws {
         // Given
         try fileStorage?.deleteFile(at: expectedGeneralAppSettingsFileURL)
-        let updateAction = AppSettingsAction.updateFeedbackStatus(type: .productsM5, status: .dismissed) { _ in }
+        let updateAction = AppSettingsAction.updateFeedbackStatus(type: .productsVariations, status: .dismissed) { _ in }
         subject?.onAction(updateAction)
 
         // When
         var visibilityResult: Result<Bool, Error>?
-        let queryAction = AppSettingsAction.loadFeedbackVisibility(type: .productsM5) { result in
+        let queryAction = AppSettingsAction.loadFeedbackVisibility(type: .productsVariations) { result in
             visibilityResult = result
         }
         subject?.onAction(queryAction)
@@ -395,12 +395,12 @@ final class AppSettingsStoreTests: XCTestCase {
     func test_loadFeedbackVisibility_for_productsM5_returns_false_after_marking_it_as_given() throws {
         // Given
         try fileStorage?.deleteFile(at: expectedGeneralAppSettingsFileURL)
-        let updateAction = AppSettingsAction.updateFeedbackStatus(type: .productsM5, status: .given(Date())) { _ in }
+        let updateAction = AppSettingsAction.updateFeedbackStatus(type: .productsVariations, status: .given(Date())) { _ in }
         subject?.onAction(updateAction)
 
         // When
         var visibilityResult: Result<Bool, Error>?
-        let queryAction = AppSettingsAction.loadFeedbackVisibility(type: .productsM5) { result in
+        let queryAction = AppSettingsAction.loadFeedbackVisibility(type: .productsVariations) { result in
             visibilityResult = result
         }
         subject?.onAction(queryAction)